Skip to content

refactor(triage): mark stale closures with stable metadata - #5493

Closed
purp wants to merge 33 commits into
NVIDIA:pull-request/5355from
purp:refactor/5487-mark-stale-closures/purp
Closed

purp wants to merge 33 commits into
NVIDIA:pull-request/5355from
purp:refactor/5487-mark-stale-closures/purp

Conversation

@purp

@purp purp commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Mark stale issue closing comments with <!-- openshell:stale-closure:v1 --> and use a shared is_stale_closed predicate to distinguish them from other automated closures. Existing unmarked closures remain held for human disposition, with no fallback based on message wording or configured day counts.

Related Issue

Closes #5487.

Verified target-repository ADMIN access; #5487 has no acceptance label.

Changes

  • Emit the versioned marker on its own line in the stale workflow's issue closing comment.
  • Extract the importable predicate into tasks/scripts/stale_closure.py; require the current stale label, not_planned closure, expected GitHub Actions bot identity, and matching close event.
  • Read the comment immediately preceding the current closure in the close/reopen/comment timeline, including across page boundaries. Require an unedited marked comment by that same bot, posted within five minutes before closure. Reject copied markers, older closure cycles, and unrelated bot closures.
  • Retain closure comment evidence in lifecycle facts and document historical unmarked handling in the labeling skill. The marker is a protocol identifier, not a cryptographic signature; validation requires trusted GitHub API responses.

Testing

  • 222 offline tests: 217 labeling tests plus 5 marker contract tests, covering valid closures, missing/copied/edited markers, wrong actors/events, old/reopened cycles, pagination, and arbitrary prose/day counts.
  • Python syntax checks, skill inventory/internal metadata and changed skill links, and git diff --check.
  • Live read-only GraphQL query validation against GitHub.
  • Workflow literal-block/marker contract test.
  • Ruff lint and formatting checks pass after merging current main.
  • Full YAML parsing and Actionlint were unavailable locally; not claimed as passing. The workflow was not dispatched, and no issues were closed or relabeled.
  • E2E tests are not applicable to this repository automation change.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Related labeling skill updated; no product architecture or published documentation changes required

purp added 30 commits November 11, 2026 07:25
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
purp added 3 commits November 11, 2026 14:28
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 11, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@copy-pr-bot
copy-pr-bot Bot force-pushed the pull-request/5355 branch 2 times, most recently from 6c31662 to 29b4687 Compare November 11, 2026 21:44
@copy-pr-bot
copy-pr-bot Bot deleted the branch NVIDIA:pull-request/5355 November 12, 2026 13:02
@copy-pr-bot copy-pr-bot Bot closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant