Skip to content

chore(review): support independent SDK language reviewer topics - #5503

Merged
purp merged 3 commits into
NVIDIA:mainfrom
purp:chore/5502-label-taxonomy-preparation/purp
Nov 12, 2026
Merged

purp merged 3 commits into
NVIDIA:mainfrom
purp:chore/5502-label-taxonomy-preparation/purp

Conversation

@purp

@purp purp commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Make reviewer routing recognize nested SDK language topics and add their initial reviewer rosters. The broad topic:sdk category is removed in favor of the four language topics. Remove the obsolete L7 exclusion from the networking scope.

Related Issue

Closes #5502. Permanent preparation for #5151; live label-definition rollout remains in the parent issue.

Verified target-repository ADMIN access; #5502 has no acceptance label.

Changes

  • Support nested topic names while rejecting malformed headings.
  • Copy the existing broad SDK reviewers into each Go, Python, Rust, and TypeScript section. Individual membership refinements follow separately.
  • Remove the broad SDK roster/category. Classify cross-SDK work with each supported language topic.
  • Keep regression coverage for nested topic routing without a parent topic.

One-time catalog, preview tool, tests, and runbook live only on purp/label-migration-tools in purp/OpenShell. They are excluded from this PR; there is no upstream merge-and-removal cycle.

Release Notes

Testing

  • 45 reviewer-routing tests and 23 accepted-work tests pass.
  • Ruff lint/format and whitespace checks pass.
  • Updated CI results pending.
  • E2E tests (not applicable).

No repository label definitions or existing issue/PR label assignments were changed. Live rollout still requires the permanent support to land and external automation compatibility to be verified.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
@purp
purp requested review from a team, derekwaynecarr, mrunalp and sjenning as code owners November 11, 2026 22:03
@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 11, 2026
@purp
purp marked this pull request as draft November 12, 2026 03:57
@copy-pr-bot

copy-pr-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
@purp purp changed the title chore(review): prepare label taxonomy and nested SDK topics chore(review): support independent SDK language reviewer topics Nov 12, 2026
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
@purp
purp marked this pull request as ready for review November 12, 2026 04:12
@purp purp added the area:build Related to CI/CD and builds label Nov 12, 2026
@purp
purp added this pull request to the merge queue Nov 12, 2026
Merged via the queue into NVIDIA:main with commit f56384b Nov 12, 2026
96 checks passed
@purp
purp deleted the chore/5502-label-taxonomy-preparation/purp branch November 12, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build Related to CI/CD and builds state:accepted A maintainer decided OpenShell should pursue this issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: prepare reviewer routing and label definitions for taxonomy migration

2 participants