Skip to content

fix: simplify redundant error-message assertion - #385

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/test-cli-simplify-redundant-error-message
Open

fix: simplify redundant error-message assertion#385
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/test-cli-simplify-redundant-error-message

Conversation

@andrewwhitecdw

Copy link
Copy Markdown

This PR addresses the following issue in tests/unit/test_cli.py: simplify redundant error-message assertion.

Changes

  • tests/unit/test_cli.py: simplify redundant error-message assertion.

Details

--- a/tests/unit/test_cli.py
+++ b/tests/unit/test_cli.py
@@ -1,1 +1,1 @@
-    assert "Error" in result.output or "error" in result.output.lower()
+    assert "error" in result.output.lower()

Tests

Let me know if you want tests added for this fix or not.

Contributor guidelines

Per this repo's CONTRIBUTING.md:

  • All commits are signed off (Signed-off-by trailer, DCO).

Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant