Repository navigation
[https://nvbugs/6890897][test] Fix startup telemetry architecture expectation and unwaive test - #20015
Merged
Mgluhovskoi merged 1 commit intoOct 9, 2026
Conversation
…nd unwaive test Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
Collaborator
Author
|
/bot run |
Contributor
Collaborator
|
PR_Github #76854 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #76854 [ run ] completed with state |
arysef
approved these changes
Oct 9, 2026
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the stale architecture assertion in
test_startup_failure_context_e2e[after_model_config]to expectQwen3ForCausalLM, matching the Qwen3-0.6B model selected by #19178. Remove the temporary waiver added in #19945 to restore CI coverage. No production telemetry changes.Fixes NVBug 6890897.
Testing
git diff --checkpassed.Dev Engineer Review
The changes are limited to a test expectation and a waiver removal. The
after_model_configcase now expectsQwen3ForCausalLM, consistent with the Qwen3-0.6B model used by the test. No production code changes are included. The supplied context reports that local E2E execution was blocked; CI validation remains necessary.QA Engineer Review
The test
test_startup_failure_context_e2ecovers configuration-validation and post-model-configuration startup failures, including telemetry context and schema-valid event delivery. Theafter_model_configcase now checks forQwen3ForCausalLM. The waiver for this test case was removed fromwaives.txt. Search results show no matching entry in the integration test lists. Both startup-failure cases need CI validation. Coverage verdict: needs follow-up.Per-File QA Perspective
tests/unittest/usage/test_e2e_capture.py: The E2E test checks startup-failure telemetry for two failure paths; the architecture expectation changed forafter_model_config. No matching test entry appeared intests/integration/test_lists/test-db/ortests/integration/test_lists/qa/.tests/integration/test_lists/waives.txt: The waiver entry fortest_startup_failure_context_e2e[after_model_config]was removed. This restores the case from the skip list; CI should confirm that it runs successfully.