Skip to content

chore: Refactor imports inside tensorrt_llm._torch. - #3015

Merged
yuxianq merged 2 commits into
NVIDIA:mainfrom
yuxianq:user/yuxianq/relative-import
Mar 26, 2025
Merged

chore: Refactor imports inside tensorrt_llm._torch.#3015
yuxianq merged 2 commits into
NVIDIA:mainfrom
yuxianq:user/yuxianq/relative-import

Conversation

@yuxianq

@yuxianq yuxianq commented Mar 24, 2025

Copy link
Copy Markdown
Collaborator

This MR contains the following updates:

  1. Use relative imports among packages inside tensorrt_llm._torch. tensorrt_llm._torch is a temporary name, using relative imports make it easier to rename/move it later.
  2. Remove import * inside tensorrt_llm/_torch (except tensorrt_llm/_torch/auto_deploy)

@yuxianq
yuxianq requested review from QiJune, dcampora and lfr-0531 March 24, 2025 08:37
QiJune
QiJune approved these changes Mar 24, 2025
View reviewed changes

@QiJune QiJune left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuxianq

yuxianq commented Mar 24, 2025

Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test

@yuxianq
yuxianq enabled auto-merge (squash) March 24, 2025 08:42
@niukuo

niukuo commented Mar 24, 2025

Copy link
Copy Markdown
Collaborator

PR_Github #273 [ run ] triggered by Bot

@juney-nvidia juney-nvidia changed the title Refactor imports inside tensorrt_llm._torch. chore: Refactor imports inside tensorrt_llm._torch. Mar 24, 2025
@niukuo

niukuo commented Mar 24, 2025

Copy link
Copy Markdown
Collaborator

PR_Github #273 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #263 completed with status: 'FAILURE'

@yuxianq

yuxianq commented Mar 25, 2025

Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test

@niukuo

niukuo commented Mar 25, 2025

Copy link
Copy Markdown
Collaborator

PR_Github #357 [ run ] triggered by Bot

lfr-0531
lfr-0531 approved these changes Mar 25, 2025
View reviewed changes

@lfr-0531 lfr-0531 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@niukuo

niukuo commented Mar 25, 2025

Copy link
Copy Markdown
Collaborator

PR_Github #357 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #326 completed with status: 'FAILURE'

@yuxianq
Refactor imports inside tensorrt_llm._torch.
e6ad1be 
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
@yuxianq
yuxianq force-pushed the user/yuxianq/relative-import branch from 7480797 to e6ad1be Compare March 25, 2025 12:59
@yuxianq

yuxianq commented Mar 25, 2025

Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test

@niukuo

niukuo commented Mar 25, 2025

Copy link
Copy Markdown
Collaborator

PR_Github #438 [ run ] triggered by Bot

@niukuo

niukuo commented Mar 25, 2025

Copy link
Copy Markdown
Collaborator

PR_Github #438 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #375 completed with status: 'SUCCESS'

@yuxianq

yuxianq commented Mar 26, 2025

Copy link
Copy Markdown
Collaborator Author

/bot reuese-pipeline

@yuxianq

yuxianq commented Mar 26, 2025

Copy link
Copy Markdown
Collaborator Author

/bot reuse-pipeline

@niukuo

niukuo commented Mar 26, 2025

Copy link
Copy Markdown
Collaborator

PR_Github #500 [ reuse-pipeline ] triggered by Bot

@niukuo

niukuo commented Mar 26, 2025

Copy link
Copy Markdown
Collaborator

PR_Github #500 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #438 for commit daf5a78

@yuxianq
yuxianq merged commit 268933b into NVIDIA:main Mar 26, 2025
wu1du2 pushed a commit to wu1du2/TensorRT-LLM that referenced this pull request May 11, 2025
@yuxianq
Refactor imports inside tensorrt_llm._torch. (NVIDIA#3015)
5290d59 
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
@niukuo niukuo mentioned this pull request Oct 12, 2026
Merged
1 task done
This was referenced Oct 14, 2026
Merged
Merged
@yuxianq yuxianq mentioned this pull request Oct 19, 2026
Merged
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QiJune QiJune QiJune approved these changes
@lfr-0531 lfr-0531 lfr-0531 approved these changes
@dcampora dcampora Awaiting requested review from dcampora

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yuxianq @niukuo @QiJune @lfr-0531