Skip to content

[PyTorch] Remove stale xfail for selective attention recompute - #3531

Merged
ptrendx merged 1 commit into
NVIDIA:mainfrom
negvet:fix_attn_ci_hybrid
Sep 16, 2026
Merged

ptrendx merged 1 commit into
NVIDIA:mainfrom
negvet:fix_attn_ci_hybrid

Conversation

@negvet

@negvet negvet commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Description

Please include a brief summary of the changes, relevant motivation and context.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Evgeny <etsykunov@nvidia.com>
@negvet

negvet commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator Author

/te-ci pytorch

@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because it only enables an existing test whose saved-tensor lifecycle is supported by the current implementation.

Summary

This PR removes a stale expected-failure marker from the selective attention recompute hybrid-quantization test.

  • Deletes the dedicated AttributeError xfail definition.
  • Allows the bitwise recompute comparison to run normally on supported hardware.
  • Retains the separate expected failure for unsupported columnwise per-tensor FP8 configurations.

Reviews (1) · Last reviewed commit: "Remove stale xfail for selective attenti..."

@ptrendx
ptrendx merged commit 8e98b77 into NVIDIA:main Sep 16, 2026
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants