Repository navigation
Conversation
amshinde
approved these changes
Sep 15, 2026
Signed-off-by: Jer Miller <jeremie.miller@gmail.com>
quartzjer
force-pushed
the
fix/third-party-warning-boundaries
branch
from
October 7, 2026 17:20
823d0aa to
723eb8e
Compare
Contributor
Author
|
rebased onto 2026.10.02, still one commit. the conflicts were context only: the new zcbor and generated include dirs sit in the same checked in the
the image ships CMake 3.22, and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COMPILE_WARNING_AS_ERRORfor the vendored fmt and spdlog targetsSYSTEMat each SDK, CLI, and test consumer without changing first-party include classificationFixes #32.
Testing
nv-attestation-cliwith tests enabled on macOS 26.5, AppleClang 21.0.0, arm64fmtandspdlogtargets; the libc++ deprecation warnings remain visible but no longer fail the build-Werror;nvat,nvattest, and both test targets retain it and use the two vendored roots via-isystem