Repository navigation
[CUB, docs-only] Adds docs page on the requirements users can express for DeviceTopK and DeviceBatchedTopK - #9446
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
OverviewThis pull request adds a new CUB documentation page that explains how to express user requirements for the top-k algorithm family (including ChangesDocumentation updates
WalkthroughUpdates the ChangesDeviceTopK Requirements Documentation
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment has been minimized.
This comment has been minimized.
DeviceTopK and DeviceBatchedTopKDeviceTopK and DeviceBatchedTopK
6d27715 to
2011698
Compare
🥳 CI Workflow Results🟩 Finished in 1h 29m: Pass: 100%/287 | Total: 1d 19h | Max: 1h 04m | Hits: 99%/196426See results here. |
jrhemstad
left a comment
There was a problem hiding this comment.
These additions are chefs kiss.
I really like your table of worked examples and including both a behavior debugging guide as well as guidance for what options to use based on desired outcome.
This is how reference docs should be done!
Understanding the top-k
requirementsthat users can express, such as determinism, tie-break, and output-ordering are quite involved. While they are common in the LLM application domain, it may be challenging to grasp for other users. This PR adds a page, describing the determinism, tie-break, and output-ordering requirement that we plan to use with the top-k family of algorithms (e.g.,DeviceTopKandDeviceBatchedTopK).Docs are based on #9354.
The plan is to only link this page from the top-k algorithms for now and only add them to the toctree as a follow-up once #9350 is merged.
Previews: