Repository navigation
Conversation
Collaborator
|
Can we add some accuracy benchmark instruction or some references of whether this is correct? |
nvluxiaoz
reviewed
Aug 25, 2026
Collaborator
Author
|
Requesting reviews from @nvluxiaoz @qmiao-hub @rickzw so that we can merge this PR. Thanks! |
nvluxiaoz
approved these changes
Aug 28, 2026
nvluxiaoz
left a comment
nvluxiaoz
left a comment
Collaborator
There was a problem hiding this comment.
LGTM as long as ever has validated.
rickzw
reviewed
Sep 1, 2026
Align the TensorRT-Edge-LLM policy notebook with the vLLM-Omni/SGLang observation (640x540 multiview + pick-and-place prompt) instead of the reasoner still and upstream CLI placeholder.
rickzw
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cookbooks/cosmos3/README.md. Policy needs-DBUILD_EXPERIMENTAL_MODELS=ON.Testing
Tested on an x86 developer GPU (RTX PRO 6000, SM120) with TensorRT-Edge-LLM v0.10.0. Both added notebooks in this PR were run top-to-bottom (
run_with_trt_edge_llm.ipynbandrun_policy_with_trt_edge_llm.ipynb).--task reasoning→llm_build+visual_build→llm_inferenceonrobot_153.jpg. Pipeline finished.--task policy→cosmos3_policy_build→cosmos3_policy_inference.[1,16,10],finite=true, ~195 ms (runtime smoke).On this SM120 box the pipeline succeeded for both notebooks (export, engine build, and C++ inference finished; policy returned
[1,16,10]withfinite=true). Reasoner captions were not usable (text did not matchrobot_153.jpg); policy was only checked as a finite action tensor, not DROID quality.Likely cause: TensorRT engines and ViT/FMHA kernels are SM-specific. The device used for this testing is RTX PRO 6000. Official Edge-LLM targets are Thor / Spark / Orin, etc. I do not have an Official Edge-LLM device (Jetson Thor / DRIVE Thor / DGX Spark / Orin), so caption or policy quality on those SKUs are not checked. x86 is Developer-only; on this SM120 box reasoner captions were not usable and should not be treated as gold. Re-run is needed on Thor, or Spark) before treating quality as validated.
The above issue has been resolved (please refer to the comment threads below).