Skip to content

[gpu-op] Helm ignores driver.licensingConfig.nlsEnabled: false in NVIDIADriver template #3211

Open

Description

@rahulait

Rendering the helm chart with --set driver.nvidiaDriverCRD.enabled=true --set driver.licensingConfig.secretName=foo --set driver.licensingConfig.nlsEnabled=false results in a rendered NVIDIADriver CR that has spec.licensingConfig.nlsEnabled=true.

nlsEnabled: {{ .Values.driver.licensingConfig.nlsEnabled | default true }}
needs to be fixed so that false can actually be configured.

Activity

  1. added
    bugIssue/PR to expose/discuss/fix a bug
    on Nov 9, 2026
  2. added
    good-first-issueIssues that are friendly to new contributors
    and removed
    bugIssue/PR to expose/discuss/fix a bug
    needs-triageissue or PR has not been assigned a priority-px label
    on Nov 9, 2026
  3. Ajax-1 commented on Nov 10, 2026

    @Ajax-1
    Contributor

    I've opened #3215 for this. default treats false as empty, so nlsEnabled: false always fell back to true. The PR switches both licensingConfig branches in templates/nvidiadriver.yaml to hasKey, so true is only used when the key is not set. Happy to adjust if you'd prefer a different approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good-first-issueIssues that are friendly to new contributors

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions