Repository navigation
fix(driver): default the unset fields of a partial startupProbe #3133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
blacksoxx
wants to merge
1
commit into
NVIDIA:main
Choose a base branch
from
blacksoxx:fix-driver-partial-startupprobe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Explicit zero startup delay is lost
When a driver specifies
initialDelaySeconds: 0,applyStartupProbeDefaultsreplaces it with 60 seconds, or 5 for precompiled drivers. The first startup check runs late despite the valid zero-delay setting.Learn more
The NVIDIADriver probe fields are int32 values with
omitempty, so the decoded Go value cannot distinguish an omitted delay from an explicit zero. Kubernetes accepts zero as an initial delay, and the DaemonSet template previously rendered that zero directly. Filling every zero delay therefore changes behavior for existing resources withinitialDelaySeconds: 0.Example: A driver with
startupProbe: {initialDelaySeconds: 0, failureThreshold: 120}previously started probing immediately. After this change, a standard driver waits 60 seconds before its first probe.Recommended fix: Preserve an explicitly supplied zero delay while still defaulting an omitted delay. This requires tracking field presence (for example with a pointer field and corresponding CRD/deepcopy updates) or selecting an omission behavior that does not silently reinterpret a user's zero. Add a regression test using an explicit zero in a CR and verify the rendered DaemonSet probe.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - this is deliberate and matches the existing ClusterPolicy path:
setContainerProbe(controllers/object_controls.go) also treats a zero field as unset and applies the default.ContainerProbeSpecfields areint32, not pointers, so an explicit0is indistinguishable from unset; I kept the two paths consistent rather than diverging one. Distinguishing an explicit zero delay would be a separate change to both paths (e.g. pointer fields).