Repository navigation
Honor explicit nlsEnabled=false in NVIDIADriver helm template #3215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -73,11 +73,11 @@ spec: | |
| {{- if .Values.driver.licensingConfig.secretName }} | ||
| licensingConfig: | ||
| secretName: {{ .Values.driver.licensingConfig.secretName }} | ||
| nlsEnabled: {{ .Values.driver.licensingConfig.nlsEnabled | default true }} | ||
| nlsEnabled: {{ if hasKey .Values.driver.licensingConfig "nlsEnabled" }}{{ .Values.driver.licensingConfig.nlsEnabled }}{{ else }}true{{ end }} | ||
| {{- else if .Values.driver.licensingConfig.configMapName }} | ||
| licensingConfig: | ||
| name: {{ .Values.driver.licensingConfig.configMapName }} | ||
| nlsEnabled: {{ .Values.driver.licensingConfig.nlsEnabled | default true }} | ||
| nlsEnabled: {{ if hasKey .Values.driver.licensingConfig "nlsEnabled" }}{{ .Values.driver.licensingConfig.nlsEnabled }}{{ else }}true{{ end }} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Licensing fix lacks a regression test Both Learn moreThis bug fix changes rendering in both licensing source branches, but the PR contains no new test. Testing conventions explicitly require a regression test that fails without a bug fix, and the chart is the supported installation path. Example: If either branch reverts to Recommended fix: Add automated rendering checks for Was this helpful? React with 👍 or 👎 to provide feedback. |
||
| {{- end }} | ||
| {{- if .Values.driver.virtualTopology.config }} | ||
| virtualTopologyConfig: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Empty licensing override breaks driver upgrades
With an empty
nlsEnabledoverride,hasKeyrenders a blank value instead of the previoustrue. The NVIDIADriver CRD requires a boolean, so Helm cannot apply the resource.Learn more
The chart accepts Helm overrides for licensing settings. Helm's
--set-string driver.licensingConfig.nlsEnabled=leaves a present key with an empty string, sohasKeytakes the value branch and producesnlsEnabled:with a null YAML value. The NVIDIADriver schema requires a boolean. The previousdefault truetreated the empty string as missing and produced valid YAML. Both licensing source branches use the same new expression.Example: An install with
driver.licensingConfig.secretName=licenseanddriver.licensingConfig.nlsEnabled=renderednlsEnabled: truebefore this change. On upgrade it rendersnlsEnabled:and Kubernetes rejects the NVIDIADriver.Recommended fix: Preserve
falseexplicitly while treating empty or null overrides as unset in both branches; add render checks for false and empty values.Was this helpful? React with 👍 or 👎 to provide feedback.