Skip to content

Bump k8s-operator-libs to 2026-10-20 (42ee2fff224f) - #3263

Merged
rajathagasthya merged 1 commit into
NVIDIA:mainfrom
aryangorwade:bump-operator-libs-20261020
Nov 18, 2026
Merged

rajathagasthya merged 1 commit into
NVIDIA:mainfrom
aryangorwade:bump-operator-libs-20261020

Conversation

@aryangorwade

@aryangorwade aryangorwade commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Addresses #722 (Scalability: reduce log lines)

This PR bumps k8s-operator-libs to the current version.

gpu-operator main currently vendors k8s-operator-libs d720f2557494 (2026-06-29). This version predates commit 60f980a (2026-08-24, "Index pods by controller UID in one pass"). In it, BuildState calls GetPodsOwnedbyDs once per driver DaemonSet with the full driver Pod list, so a pass writes (number of driver DaemonSets) x (number of driver pods) "Pod" log lines, plus a full Pod log dump for each pod of another driver DaemonSet.

With more than one driver DaemonSet (precompiled kernel pools, NVIDIADriver CRs), this library bump reduces these lines.

Baseline versus library bump

NOTE: Reducing logging overhead can allow more reconciliation passes during an upgrade because fewer events are combined. Because of this the remaining info-level messages can appear more often, increasing or barely reducing total upgrade log lines despite the improvements.

Workers Scenario Idle lines/s Upgrade lines/s Upgrade seconds Upgrade lines
500 Baseline GPU Operator with its original pinned library 2.300 457.488 232.332 106,289
500 Baseline GPU Operator with library bumped to 42ee2fff224f (this PR) 1.706 449.583 233.156 104,823
2,500 Baseline GPU Operator with its original pinned library 4.267 471.600 1,231.013 580,546
2,500 Baseline GPU Operator with library bumped to 42ee2fff224f (this PR) 3.348 427.501 1,391.251 594,761

Measurements use a kind control plane with KWOK workers, two driver DaemonSets, and a CPU-only simulated driver-upgrade workflow. Rates count all emitted operator output with info-level configuration and default production Zap sampling. One valid capture per phase and worker count was selected; every idle window includes two complete upgrade-library passes.


Devin Review

Signed-off-by: Aryan Gorwade <gorwadearyan@gmail.com>

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@aryangorwade
aryangorwade marked this pull request as ready for review November 18, 2026 01:35
@aryangorwade
aryangorwade requested a review from a team as a code owner November 18, 2026 01:35
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The go.mod requirement for github.com/NVIDIA/k8s-operator-libs changes from v0.0.0-20260629200812-d720f2557494 to v0.0.0-20261020171813-42ee2fff224f.

Merge Risk: Minimal · up to 55267

This updates the upgrade library to a newer revision to reduce repeated log lines. No concrete problem was found; normal build and test checks should confirm that the upgrade call sites still compile.

Architecture risk: Low · up to 55267

The change affects 1 system.

Changed systems: go.mod

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — go.mod (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in go.mod: The required version of github.com/NVIDIA/k8s-operator-libs changes from v0.0.0-20260629200812-d720f2557494 to v0.0.0-20261020171813-42ee2fff224f.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 246a9ca and 55267bd.

Files ignored due to path filters: 7

  • go.sum is excluded by !**/*.sum, !go.sum
  • vendor/github.com/NVIDIA/k8s-operator-libs/pkg/upgrade/common_manager.go is excluded by !vendor/**
  • vendor/github.com/NVIDIA/k8s-operator-libs/pkg/upgrade/consts.go is excluded by !vendor/**
  • vendor/github.com/NVIDIA/k8s-operator-libs/pkg/upgrade/drain_manager.go is excluded by !vendor/**
  • vendor/github.com/NVIDIA/k8s-operator-libs/pkg/upgrade/upgrade_state.go is excluded by !vendor/**
  • vendor/github.com/NVIDIA/k8s-operator-libs/pkg/upgrade/util.go is excluded by !vendor/**
  • vendor/modules.txt is excluded by !vendor/**
Files selected for processing: 1

  • go.mod

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

@rajathagasthya
rajathagasthya merged commit 9e39c65 into NVIDIA:main Nov 18, 2026
42 checks passed
@aryangorwade aryangorwade self-assigned this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants