You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Remove default MIG config ConfigMap and its mount - #3268
The default-mig-parted-config ConfigMap was mounted into mig-manager as config-default.yaml, a fallback for R535 drivers that cannot list MIG
profiles while MIG mode is disabled. R535 is no longer supported.
This reverts commit db0bb63. The mig-parted-config volume is again
added only when migManager.config.name is set. The certification suite
now selects the single-strategy profile from the custom ConfigMap when
one is set, and from the per-node ConfigMap otherwise.
NVIDIA/mig-parted#598 removes the matching fallback from mig-manager and
publishes the per-node ConfigMap also when a custom config is set.
Older mig-manager versions treat DEFAULT_CONFIG_FILE as optional. On
upgrade, an existing default-mig-parted-config ConfigMap stays until
the ClusterPolicy is deleted. Nothing reads it.
Checklist
No secrets, sensitive information, or unrelated changes
go test ./controllers/ passes, including the updated TestMIGManager
and TestTransformMigManager. The certification suite changes are
checked with go build and go vet only; they have no unit tests.
The change removes the bundled default MIG-parted ConfigMap and its DaemonSet volume and mount. TransformMIGManager no longer selects a default configuration file. When a custom ConfigMap is configured, it adds a volume and mount and sets CONFIG_FILE to /mig-parted-config/config.yaml. Tests now expect no configuration volume or environment entry by default.
Merge Risk: Low · up to c1b56
Removing the bundled default MIG configuration looks consistent with the stated intent that R535 is no longer supported. The default-case test does not catch a leftover config environment variable, so a regression there could go unnoticed. Add the negative env assertions before or shortly after merge.
Security architecture risk: Minimal · up to c1b56
The inspected change does not establish an introduced security, containment, ownership, or rollback regression. Custom configuration retains its existing trust boundary, and reconciliation removes obsolete pod bindings. Compatibility with external MIG Manager versions remains unverified.
Retained concerns
No architecture-level concerns identified.
Security review details
Security Blast Radius
inferred — The affected execution scope is MIG Manager on nodes selected for GPU management, not merely a configuration file in the controller. Configuration influences an already privileged component with host mounts; the PR does not expand that deployment or privilege scope in the inspected changes.
Trust Boundaries and Controls
observed — The custom ConfigMap name still comes from the existing ClusterPolicy field and is bound into the DaemonSet in the operator namespace. The new mount is explicitly read-only. This preserves the existing configuration-to-privileged-manager trust relationship rather than introducing a new configuration authority.
Resilience and Maintainability Implications
observed — The repository's entrypoint wrapper does not require either configuration-file environment variable before executing MIG Manager. Whether external MIG Manager versions operate correctly without the removed fallback remains outside the inspected source.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
The reason will be displayed to describe this comment to others. Learn more.
Note
Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.
Other comments: 1
controllers/object_controls_test.go: 1
2594-2594: Minor · Functional Correctness · Quick win
Assert that default configuration environment entries are absent.
With an empty expected map, the loop at Line 2667 performs no environment assertions. The default test still passes if the asset-backed DaemonSet contains DEFAULT_CONFIG_FILE pointing at the removed mount.
Explicitly reject DEFAULT_CONFIG_FILE and CONFIG_FILE in the default case. Keep the positive CONFIG_FILE assertion for custom configuration.
As per path instructions, “Flag assertions that would still pass if the behavior under test were broken.”
Reviewing files that changed from the base of the PR and between 304898f and c1b5633.
Files selected for processing: 5
assets/state-mig-manager/0400_configmap.yaml
assets/state-mig-manager/0600_daemonset.yaml
controllers/object_controls.go
controllers/object_controls_test.go
controllers/transforms_test.go
Files with no reviewable changes: 2
assets/state-mig-manager/0400_configmap.yaml
assets/state-mig-manager/0600_daemonset.yaml
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
The default-mig-parted-config ConfigMap was mounted into mig-manager as
config-default.yaml, a fallback for R535 drivers that cannot list MIG
profiles while MIG mode is disabled. R535 is no longer supported.
This reverts commit db0bb63. The mig-parted-config volume is again
added only when migManager.config.name is set. The certification suite
now selects the single-strategy profile from the custom ConfigMap when
one is set, and from the per-node ConfigMap otherwise.
Signed-off-by: Rajath Agasthya <ragasthya@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Part of #2913
Description
The
default-mig-parted-configConfigMap was mounted into mig-manager asconfig-default.yaml, a fallback for R535 drivers that cannot list MIGprofiles while MIG mode is disabled. R535 is no longer supported.
This reverts commit db0bb63. The
mig-parted-configvolume is againadded only when
migManager.config.nameis set. The certification suitenow selects the single-strategy profile from the custom ConfigMap when
one is set, and from the per-node ConfigMap otherwise.
NVIDIA/mig-parted#598 removes the matching fallback from mig-manager and
publishes the per-node ConfigMap also when a custom config is set.
Older mig-manager versions treat
DEFAULT_CONFIG_FILEas optional. Onupgrade, an existing
default-mig-parted-configConfigMap stays untilthe ClusterPolicy is deleted. Nothing reads it.
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
go test ./controllers/passes, including the updatedTestMIGManagerand
TestTransformMigManager. The certification suite changes arechecked with
go buildandgo vetonly; they have no unit tests.