Skip to content

Add optional DaemonSet filters before upgrade validation - #166

Open
aryangorwade wants to merge 1 commit into
NVIDIA:mainfrom
aryangorwade:upgrade-owner-filter
Open

aryangorwade wants to merge 1 commit into
NVIDIA:mainfrom
aryangorwade:upgrade-owner-filter

Conversation

@aryangorwade

@aryangorwade aryangorwade commented Nov 12, 2026 •

Copy link
Copy Markdown

Fixes gpu-operator #3061. Related to gpu-operator #3129

Driver DaemonSets managed by ClusterPolicy and NVIDIADriver share the app.kubernetes.io/component=nvidia-driver label. Because of this, a terminating NVIDIADriver DaemonSet can fail BuildState’s pod-count validation before the caller can exclude it, blocking ClusterPolicy driver upgrades.

Add optional DaemonSetFilter predicates to BuildState so callers can exclude unrelated DaemonSets before pod association and validation. Omitting filters preserves existing behavior (eg orphaned-pod handling).

Comment thread pkg/upgrade/upgrade_state.go Resolved
Comment thread pkg/upgrade/upgrade_state.go Resolved
Signed-off-by: Aryan Gorwade <gorwadearyan@gmail.com>
@rollandf

Copy link
Copy Markdown
Contributor

@greptileai

@greptile-apps

greptile-apps Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Adds optional per-call DaemonSet filters to BuildState so unrelated DaemonSets cannot block driver upgrades during pod-count checks.

  • BuildState lets callers exclude DaemonSets before checking their pod counts.

No actionable issues found.

Reviews (1) · Last reviewed commit: "Add optional DaemonSet filters before up..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants