Repository navigation
catalog(vss): sync from develop; keep build-vision-ai and operational skills - #587
zac-wang-nv wants to merge 1 commit into
Conversation
mosheabr
left a comment
There was a problem hiding this comment.
Thanks for this — the path and ref work is accurate, and I appreciate you calling out the prune-cap overflow upfront rather than letting the sync surprise us.
I can't merge it as it stands, though. Requesting changes on three things, all in the source repo rather than in this PR.
1. develop has no signatures. None of the nine declared paths carries a skill.oms.sig on that branch. main does — skills/vss-ask-video/skill.oms.sig is there today, which is what the catalog is currently serving.
This is the one that matters most, because it means the PR wouldn't do what you want even if I merged it. At the next sync all nine would be held with "no signature in source." The seven existing skills would keep serving their old content from main, vss-build-vision-ai and vss-generate-video-report-rag would never land, and the eight dropped skills would still be pruned. The catalog would lose eight skills and gain nothing.
2. The BENCHMARK.md files are placeholders. Each one reads Overall verdict: NOT RUN — no controlled benchmark completed, 0 attempts per task, no agents recorded. We need a real evaluation with a PASS verdict before these can publish.
3. vss-build-vision-ai has no skill card. The other eight have skill-card.md; this one doesn't.
What's already good: DCO sign-off is in place, YAML parses, every declared path does have a SKILL.md at its root, and all catalog_dir values are unique across components.d/ — I checked all of them.
The fix is to run /nvskills-ci on develop in the VSS repo so the skills get evaluated, carded and signed there, then update this PR. One heads-up: that has to run from a branch in the VSS repo itself — the signing flow doesn't work from forks, so a fork PR there would silently produce nothing.
Happy to re-review as soon as develop has the artifacts. And on the eight orphans — once the rest is sorted, tell me whether you'd like them pruned in one pass or split into two batches to stay under the cap.
… skills Point the Video Search and Summarization component at the develop branch, where the skills tree moved to skills/vss-build-vision-ai plus skills/operations/<skill>/. Drop the retired vss-deploy-profile and the per-microservice deployment, tools, and benchmarking skills; the catalog now carries the single build skill and the operational skills. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Zac Wang <zacw@nvidia.com>
fc7796b to
d33c6e3
Compare
…rchive (#2501) * chore(skills): baseline SkillSpector findings and re-run NVSkills sync for ask-video, query-analytics, search-archive Add a reviewed SkillSpector baseline for vss-search-archive (REST DELETE routes flagged as file deletion) and touch vss-ask-video and vss-query-analytics, so NVSkills CI validates and signs all three for the catalog sync (NVIDIA/skills#587). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Zac Wang <zacw@nvidia.com> * docs(skills): add the missing top-level heading to vss-query-analytics The NVSkills Tier 1 schema check (body_heading) blocked signing because SKILL.md had no # title after the frontmatter. Replaces the blank-line touch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Zac Wang <zacw@nvidia.com> * Attach NVSkills validation signatures Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> * chore(osrb): sync inventory.csv with the PR tree Signed-off-by: github-actions[bot] <41898024+github-actions[bot]@users.noreply.github.com> * Attach NVSkills validation signatures Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> * Attach NVSkills validation signatures Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> * Attach NVSkills validation signatures Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> * Attach NVSkills validation signatures Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> --------- Signed-off-by: Zac Wang <zacw@nvidia.com> Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> Signed-off-by: github-actions[bot] <41898024+github-actions[bot]@users.noreply.github.com> Signed-off-by: Hugo VERJUS <hverjus@nvidia.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> Co-authored-by: github-actions[bot] <41898024+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hugo VERJUS <hverjus@nvidia.com>
…ge (#2503) * chore(skills): baseline SkillSpector findings for manage-alerts, manage-video-io-storage Add reviewed SkillSpector baselines so NVSkills CI can validate and sign these skills for the catalog sync (NVIDIA/skills#587). Scanner false positives (REST DELETE routes, .env layer paths, local JSON checks, uvicorn) are marked temporary; the shipped SDRC docker.sock mount and UID-scoped setup are accepted; world-writable engine/log dirs and the commented-out destructive cleanup are recorded as risks to revisit. AE1 is a temporary bridge until SkillEvaluator 1.7.0 ships SkillSpector #634 and #686. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Zac Wang <zacw@nvidia.com> * docs(skills): use a non-numeric placeholder camera id in the always-on probe The NVSkills Tier 1 PII scan read 00000000-0000-0000-0000-0000000000aa as a possible credit card number and blocked signing. Any nonexistent camera id works for the probe; the doc and its eval keep the same value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Zac Wang <zacw@nvidia.com> * Attach NVSkills validation signatures Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> * chore(osrb): sync inventory.csv with the PR tree Signed-off-by: github-actions[bot] <41898024+github-actions[bot]@users.noreply.github.com> * Attach NVSkills validation signatures Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> * Attach NVSkills validation signatures Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> * docs(skills): stop recommending docker compose up --yes by default in VIOS troubleshooting The NVSkills Tier 1 semantic check (SQP-2) flagged the advice that a generated deploy script should default to --yes: it accepts every volume-recreate prompt, including drifted volumes that hold real state such as the VIOS PostgreSQL volume. Keep explicit docker volume rm as the remedy and make --yes an operator-confirmed opt-in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Zac Wang <zacw@nvidia.com> * Attach NVSkills validation signatures Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> --------- Signed-off-by: Zac Wang <zacw@nvidia.com> Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> Signed-off-by: github-actions[bot] <41898024+github-actions[bot]@users.noreply.github.com> Signed-off-by: Hugo VERJUS <hverjus@nvidia.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> Co-authored-by: github-actions[bot] <41898024+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hugo VERJUS <hverjus@nvidia.com>
…o-report-rag, summarize-video (#2502) * chore(skills): baseline SkillSpector findings for generate-video-report, generate-video-report-rag, summarize-video Add reviewed SkillSpector baselines so NVSkills CI can validate and sign these skills for the catalog sync (NVIDIA/skills#587): Compose .env layer paths and local json.tool pipes flagged by the scanner, plus a temporary AE1 bridge until SkillEvaluator 1.7.0 ships SkillSpector #634 and #686. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Zac Wang <zacw@nvidia.com> * Attach NVSkills validation signatures Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> * chore(osrb): sync inventory.csv with the PR tree Signed-off-by: github-actions[bot] <41898024+github-actions[bot]@users.noreply.github.com> * Attach NVSkills validation signatures Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> * Attach NVSkills validation signatures Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> * Attach NVSkills validation signatures Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> --------- Signed-off-by: Zac Wang <zacw@nvidia.com> Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> Signed-off-by: github-actions[bot] <41898024+github-actions[bot]@users.noreply.github.com> Signed-off-by: Hugo VERJUS <hverjus@nvidia.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> Co-authored-by: github-actions[bot] <41898024+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hugo VERJUS <hverjus@nvidia.com>
|
Closing as superseded by #726, which publishes only vss-build-vision-ai from release/3.3.0 for the 3.3.0 release. Zac confirmed the scope in our Slack thread. Thanks! |
Onboarding type
components.d/<slug>.ymlfile)All PRs
git commit -s).Other context
Update
components.d/video-search-and-summarization.ymlfor the current shape of the VSS Blueprint repo.ref: main→ref: develop. The skills tree ondevelopmoved toskills/vss-build-vision-ai/plusskills/operations/<skill>/; the flatskills/<skill>/paths the catalog currently points at no longer exist there.Keep only the build skill and the operational skills. The component now lists:
vss-build-vision-ai(replaces the retiredvss-deploy-profile)vss-ask-video,vss-generate-video-report,vss-generate-video-report-rag(new),vss-manage-alerts,vss-manage-video-io-storage,vss-query-analytics,vss-search-archive,vss-summarize-videoDropped from the catalog:
vss-deploy-profile,vss-deploy-dense-captioning,vss-deploy-detection-tracking-2d,vss-deploy-detection-tracking-3d,vss-deploy-video-embedding,vss-generate-video-calibration,vss-setup-behavior-analytics,vss-setup-video-analytics-api. These are per-microservice deployment and tooling skills that VSS no longer publishes to the catalog;vss-build-vision-aiis the single supported deployment entry point.Heads-up for the sync: that is 8 orphaned
skills/<catalog_dir>/directories, above thePRUNE_CAPof 5 inprune-orphans.sh, so the next sync will write them to the overflow list and flag for triage rather than delete them. I kept this PR to the component file only, sinceskills/,versions.json, and the.sigfiles are workflow-owned. Happy to add the deletions here if the PIC prefers, or the prune can be run in two batches.Every listed
pathwas verified to contain aSKILL.mdat its root onNVIDIA-AI-Blueprints/video-search-and-summarization@develop. YAML parses; allcatalog_dirvalues remain unique acrosscomponents.d/.🤖 Generated with Claude Code