Skip to content

add support for macos x64 and linux#68

Open
farfromrefug wants to merge 2 commits into
NativeScript:mainfrom
farfromrefug:copilot/add-support-for-x64-linux
Open

add support for macos x64 and linux#68
farfromrefug wants to merge 2 commits into
NativeScript:mainfrom
farfromrefug:copilot/add-support-for-x64-linux

Conversation

@farfromrefug
Copy link
Copy Markdown

This was done with Copilot. It seems fine from my side
I ll let you judge but i would love to use this on my computers


SimDeck packaging was constrained to macOS arm64, which blocked installation/use on x64 hosts and left Linux host support incomplete. This change broadens declared host compatibility and makes the CLI choose the correct native binary per OS/arch.

  • Platform compatibility updates

    • Expanded npm package constraints from darwin/arm64 to darwin, linux and arm64, x64.
    • Included platform-specific binary artifacts in published package contents:
      • simdeck-bin-darwin-arm64
      • simdeck-bin-darwin-x64
      • simdeck-bin-linux-arm64
      • simdeck-bin-linux-x64
  • CLI runtime binary resolution

    • Replaced hard macOS-only gating in packages/cli/bin/simdeck.mjs with host-aware resolution.
    • Added platform/arch mapping and lookup logic with fallback to build/simdeck-bin for compatibility.
  • Release workflow architecture output

    • Updated release workflow Rust target setup to build both macOS architectures.
    • Release build now emits separate macOS arm64/x64 binaries and assembles a universal simdeck-bin via lipo.
    • Updated artifact verification to assert both architectures are present.
const suffixByHost = {
  "darwin-arm64": "darwin-arm64",
  "darwin-x64": "darwin-x64",
  "linux-arm64": "linux-arm64",
  "linux-x64": "linux-x64",
};

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 01e4eacd-3eae-44b8-b51c-85e856b29c97

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DjDeveloperr
Copy link
Copy Markdown
Collaborator

I'll get Claude to fix the lint errors - I'm unable to test on Linux easily, I assume it works fine for Android emulators on Linux? 👀

@farfromrefug
Copy link
Copy Markdown
Author

@DjDeveloperr did not have time to test last night as i was on a macos. Will try to build it today and let you know

@farfromrefug
Copy link
Copy Markdown
Author

farfromrefug commented May 30, 2026

@DjDeveloperr on ubuntu i cant get android emulator stream to work, i get H264 WebSocket stream closed. Trying to debug but i dont see anything in the log. Is there something to do to enable debug log?
Can i run simdeck attached so that see errors maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants