Repository navigation
Sync upstream (20 commits, incl. release V1.3.78) - CONFLICTS - #368
Closed
github-actions[bot] wants to merge 21 commits into
Closed
github-actions[bot] wants to merge 21 commits into
github-actions[bot] wants to merge 21 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| window, client, console, DefaultPlayerEvents, PlayerModes, VideoSource, URLUtils, | ||
| EnvUtils: {isWebAudioSupported: () => false}, | ||
| }); | ||
| vm.runInContext(script('modules/EmbedAPI.mjs') + '\nglobalThis.api = new EmbedAPI(client);', context); |
| observe() {} | ||
| }, | ||
| }); | ||
| vm.runInContext(script('main.mjs').replace('setup().catch', 'globalThis.setupPromise = setup().catch'), context); |
| }}, | ||
| Localize: {getMessage: (key, args = []) => key + ': ' + args.join(' ')}, | ||
| }); | ||
| vm.runInContext(script('utils/AlertPolyfill.mjs') + '\nglobalThis.Alert = AlertPolyfill;', context); |
| }, | ||
| clearTimeout: (timer) => timers.delete(timer), | ||
| }); | ||
| vm.runInContext(contentScript, context); |
| clearTimeout: (timer) => timers.delete(timer), | ||
| }); | ||
| vm.runInContext(contentScript, context); | ||
| if (inject) vm.runInContext(injectedScript, context); |
Comment on lines
+234
to
+235
| vm.runInContext(playerScript.replace(/^import .*;\n/gm, '').replace('export default class', 'class') + | ||
| '\nglobalThis.player = Object.create(YTPlayer.prototype);', context); |
Author
|
@Nawid3333 CI fails on this pull request. It failed twice on this commit, so a flaky test is an unlikely cause.
The last lines of Lint, test and buildThe last lines of Lint workflowsThe last lines of Unit tests (Windows)The last lines of e2e (Linux, extension 2/2)The last lines of e2e (Windows, github 1/3)The last lines of e2e (Windows, playback 2/3)The last lines of e2e (Windows, extension 3/3)The last lines of e2e (Linux, playback 2/2)The last lines of e2e (Windows, extension 2/3)The last lines of e2e (Linux, github 2/2)The last lines of e2e (Windows, github 2/3)The last lines of e2e (Windows, playback 3/3)The last lines of e2e (Windows, github 3/3)The last lines of e2e (Linux, playback 1/2)The last lines of e2e (Linux, github 1/2)The last lines of e2e (Linux, extension 1/2)The last lines of e2e (Windows, extension 1/3)The last lines of e2e (Windows, playback 1/3)The pull request stays open. A new commit on it runs CI again. https://github.com/Nawid3333/FastStream/actions/runs/37894208989 |
Author
|
@Nawid3333 CI fails on this pull request. It failed twice on this commit, so a flaky test is an unlikely cause.
The last lines of Unit tests (Windows)The last lines of e2e (Linux, extension 1/2)The last lines of Lint, test and buildThe last lines of Lint workflowsThe last lines of e2e (Windows, extension 3/3)The last lines of e2e (Windows, playback 1/3)The last lines of e2e (Windows, github 2/3)The last lines of e2e (Linux, playback 1/2)The last lines of e2e (Linux, github 2/2)The last lines of e2e (Linux, github 1/2)The last lines of e2e (Windows, playback 2/3)The last lines of e2e (Linux, playback 2/2)The last lines of e2e (Linux, extension 2/2)The last lines of e2e (Windows, github 1/3)The last lines of e2e (Windows, github 3/3)The last lines of e2e (Windows, extension 1/3)The last lines of e2e (Windows, extension 2/3)The last lines of e2e (Windows, playback 3/3)The pull request stays open. A new commit on it runs CI again. https://github.com/Nawid3333/FastStream/actions/runs/37901149244 |
Owner
|
Closed on the owner's decision (2026-10-09): this fork no longer follows upstream; it is maintained on its own, Firefox-only. Of these 18 upstream commits, 13 are the owner's own upstream PRs (already in this fork), the security fix is already here (it came from the owner's report), "Fix yt" does not apply (no YouTube player here), and V1.3.78 is a version bump. The one new feature, the video aspect-ratio option (Andrews54757#552 + 3311d31), is noted for the owner's decision. The sync workflow is being replaced by a periodic upstream check that only reports changes worth reviewing as fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Nawid3333 Merging upstream/main into main produced conflicts. The branch carries the conflicted state so the markers show in the diff; CI will fail until they are resolved. Fetch
sync/upstream, resolve, and push to it.Upstream releases in this sync
Deciding
.github/and brings back no file this project deleted: a comment fromupdate-prs.ymlsays so, or says what to look at. Merge it with Create a merge commit, not Squash.docs/upstream-sync-log.md. Add to it when you decide..github/, see above), and a comment here gives the result. It starts "Review dependency changes" too, which fails when upstream's lockfile brings a package version with a high-severity advisory; the comment names it when it did not pass. (The pull request's own runs wait for an approval they do not need.) For a change to the player, the loaders or a media library, also runpnpm run test:live(real streams and sites) before merging.Upstream commits not yet in this project (merge commits are not listed)