Repository navigation
Aspect ratio back (upstream #552): Video Options choice and a cycle key - #432
Merged
Merged
Conversation
…ons, a cycle key, 16 languages Auto, 16:9, 4:3, 21:9, 1:1, 9:16, 3:2, 16:10 or stretch, in Video Options; a ratio shows the picture in the largest box of that shape, centered, stretched to it (a 4:3 show without bars beside it). A CycleAspectRatio key (none by default). Ported onto VideoTransformUtils (the CSS filter code it hooked into is gone); the label and its two words translated (upstream left English everywhere). The e2e measures the box. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your call (2026-10-11), for darklight's #429 (4:3 Dragon Ball with bars beside it): the aspect-ratio option from upstream, back in this fork.
What it does: Options > Video Options > Aspect ratio: Auto (the video's own), 16:9, 4:3, 21:9, 1:1, 9:16, 3:2, 16:10, or Stretch to fill. A ratio shows the picture in the largest box of that shape that fits the player, centred, and stretches the picture to it; Stretch fills the whole player. A Cycle aspect ratio key (no key by default; set one under Keybinds) goes Auto, the ratios, Stretch, Auto again.
Port: upstream Andrews54757#552 (GroupXyz,
3b3d1eb2) and Andrew's fix (3311d313, the container-query box), ontoVideoTransformUtils/updateVideoTransform(theCSSFilterUtilsit hooked into went with the video filters, 2026-10-10), for the player and the seek preview. Upstream left the label in English in every language; it is translated here (gemma4 draft, glm check), with "Auto" and "Stretch" as words of their own.Tests: unit (
VideoTransformUtils.getAspectRatioStyles: auto/unknown, ratios, stretch); e2eplayer-controlsmeasures the video's box on screen (4:3 is 4:3, full height, centred; stretch fills; auto as the video; the key cycles); options-fields (23), player-controls (22), vitest (2241), lint, tsc.🤖 Generated with Claude Code