Repository navigation
build(pnpm): undici 6.29.0 and 7.30.0 for Dependabot #30-#42 - #63
Merged
Merged
Conversation
Thirteen alerts (ten advisories) on undici, all fixed from 6.28.1 or 7.29.1. webdriver (undici ^6.27.0) and addons-linter's cheerio (undici ^7.19.0) both allow the patched undici, but pnpm keeps the locked 6.28.0 and 7.29.0 even on `pnpm update undici`, and Dependabot's own update ends in update_not_possible. Two overrides, one per major, next to the existing Dependabot ones. Dev-only: nothing from undici ships in the extension. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Dependabot alerts #30 to #42: thirteen alerts (three high, six moderate, four low), from ten undici advisories. Every one is fixed from undici 6.28.1 on the 6 line and 7.29.1 on the 7 line. All are development-only: nothing from undici ships in the extension.
Why pnpm kept the old versions
undici 6.28.0 comes through webdriver 9.32.0, the e2e test driver (WebdriverIO), which asks for undici ^6.27.0. undici 7.29.0 comes through cheerio 1.2.0, pulled in by addons-linter 10.13.0, the Firefox add-on linter, which asks for ^7.19.0. Both of those ranges already allow the patched versions, but pnpm keeps the locked versions:
pnpm update undici, also with--depth, andpnpm audit --fix updatechanged nothing. Dependabot's own security update ran twice today and ended in "update_not_possible", so it opened no PR.Fix
Two overrides in
pnpm-workspace.yaml, next to the existing Dependabot overrides and with the same kind of comment:undici@6: ^6.28.1andundici@7: ^7.29.1. One per major, so webdriver keeps 6 and cheerio keeps 7.In
pnpm-lock.yaml: undici 6.28.0 -> 6.29.0 and 7.29.0 -> 7.30.0, nothing else changed. webdriver now loads undici 6.29.0 and cheerio 7.30.0.pnpm auditsays "No known vulnerabilities found", but npm's audit data lists only #30/#31 so far. For #32 to #42 I checked every range of each GitHub advisory: none reaches 6.29.0 or 7.30.0.No release: the extension's build is unchanged, so auto-release will find it identical to the latest release and skip.
Checked
verifypassed on Windows (Firefox 156).verify:linuxpassed on Ubuntu 24.04 and 26.04 (Firefox 157), with one retry in mp4-fragmented-end, a known test-timing flake that passed on the retry. Intest:live, everything passed except the two Shaka Angel One HLS cases. They fail the same way on main: the player opens one of the stream's.mp4segments instead of the playlist. That is the feat(detection): find manifests by their Content-Type, and play the longest stream #50 regression fix(detection): a stream's .mp4 pieces no longer outrank its manifest #61 fixes.🤖 Generated with Claude Code