Repository navigation
Conversation
Member
|
Can you please confirm LLM involvement in this MR and contribute it respectively. |
Author
|
Yes, I used Claude Opus and GPT to help trace the migration code and draft the patch. I reviewed every line, ran the regression tests, and have been running it on my Android 16 phone with no layout resets. The change is my responsibility either way. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the saved home screen when a grid migration fails instead of resetting it. Only switch databases and update migration state after success. On failure, stop loading before defaults or widget cleanup can replace saved data, and show an error message.
Related reports: #284, #308, #337, #343, #359, #362, #378, #385, #473, #505 and #515. These include older versions and different triggers; this change addresses migration failures, not every reported reset.
All 11 regression tests pass. The debug build was also installed and checked on Android 16.
Oh I've been running this on my phone for some time and i haven't seen crashes and layout resets so far, so it seems like this issue is fixed, filnally :)