Fix params not being hash by default

[mhluska]

This fixes a minor thing that has been nagging at me for a while: I always had to do params && params[:foo] in an attribute block because params is undefined unless the controller explicitly passes it. I think we should be able to expect params to always be defined.

The bug occurs when no options are passed and the early return return if options.blank? prevents params being set to {} by default.

[manojmj92]

Fantastic! Thank you for this fix! :)

…

On Thu, Oct 18, 2018, 9:31 PM Maros Hluska ***@***.***> wrote: This fixes a minor thing that has been nagging at me for a while: I always had to do params && params[:foo] in an attribute block because params is undefined unless the controller explicitly passes it. ------------------------------ You can view, comment on, or merge this pull request online at: #339 Commit Summary - Fix params not being hash by default File Changes - *M* lib/fast_jsonapi/object_serializer.rb <https://github.com/Netflix/fast_jsonapi/pull/339/files#diff-0> (2) - *M* spec/lib/object_serializer_attribute_param_spec.rb <https://github.com/Netflix/fast_jsonapi/pull/339/files#diff-1> (2) - *M* spec/lib/object_serializer_spec.rb <https://github.com/Netflix/fast_jsonapi/pull/339/files#diff-2> (6) - *M* spec/shared/contexts/movie_context.rb <https://github.com/Netflix/fast_jsonapi/pull/339/files#diff-3> (20) Patch Links: - https://github.com/Netflix/fast_jsonapi/pull/339.patch - https://github.com/Netflix/fast_jsonapi/pull/339.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#339>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AD2OweDw5edb6gh_ryaXEinP0WWdVkfLks5umKXUgaJpZM4XtwvB> .