Repository navigation
fix(update-module): handle missing PREV_IMAGE_URL - #1340
Merged
Merged
Conversation
The cleanup step crashed with KeyError when PREV_IMAGE_URL was not set. This happens when a module that was never updated before is updated to the image URL it already runs, without the force flag: the pull step exits early and does not record the previous image. Skip the old image removal when no previous image is recorded, as the cluster update-module action already does. Assisted-by: Claude Code:claude-opus-5-5
stephdl
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating a module that was never updated before, using the same image URL it already runs and without
--force, makes theupdate-moduletask fail withKeyError: 'PREV_IMAGE_URL'in step95cleanup_images. See NethServer/dev#8180.The cleanup step now skips the old image removal when no previous image is recorded, like the cluster
update-moduleaction already does. Normal updates and--forceupdates behave as before.How to test
add-module ghcr.io/nethserver/dokuwiki:latest 1update-module ghcr.io/nethserver/dokuwiki:latest dokuwiki1Generated by Claude Code:claude-opus-5-5 with nethserver-pr