Skip to content

Set manual trigger for Chromatic workflow - #24

Merged
CodyCBakerPhD merged 2 commits into
mainfrom
make_chromatic_manual_trigger
Mar 10, 2023
Merged

CodyCBakerPhD merged 2 commits into
mainfrom
make_chromatic_manual_trigger

Conversation

@CodyCBakerPhD

Copy link
Copy Markdown
Collaborator

Towards the goal of testing out Chromatic (free version) on #19, setting trigger for workflow to only occur manually

@CodyCBakerPhD CodyCBakerPhD self-assigned this Mar 9, 2023

@garrettmflynn garrettmflynn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Let me know when you've got an instance running, I'd love to see how it feels to interact with the Chromatic UI

@CodyCBakerPhD

Copy link
Copy Markdown
Collaborator Author

Let me know when you've got an instance running, I'd love to see how it feels to interact with the Chromatic UI

Ahhh I was going to ask if you could handle trying to get that setup 😆 I don't think I have the time right now, plus would be good experience for you to learn how that GitHub action works

@CodyCBakerPhD

Copy link
Copy Markdown
Collaborator Author

The action will for sure need to set a secret variable or two, so if you aren't able to control that just send the tokens to me over a secure line and I'll add them as soon as I can

@garrettmflynn

Copy link
Copy Markdown
Member

Okay yeah, I was gonna do that originally—but I don't have the required permissions in this repo to access the Settings tab.

@garrettmflynn garrettmflynn mentioned this pull request Mar 10, 2023
@garrettmflynn

garrettmflynn commented Mar 10, 2023 •

Copy link
Copy Markdown
Member

Just to note, Chromatic cannot (yet) test #19 as those elements are not components in Storybook. I've created #26 to install Chromatic and have manually tested this installation with a change to the multi-select form component.

@CodyCBakerPhD
CodyCBakerPhD merged commit 2c6bd87 into main Mar 10, 2023
@CodyCBakerPhD
CodyCBakerPhD deleted the make_chromatic_manual_trigger branch March 10, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants