Repository navigation
verify: remove the unused resident_plan_par_kernel (CUDA and SYCL); INTEL.md no longer names STRATA_PLAN_PARALLEL - #1554
Closed
stuchapin909 wants to merge 1 commit into
Closed
stuchapin909 wants to merge 1 commit into
stuchapin909 wants to merge 1 commit into
Conversation
…NTEL.md no longer names STRATA_PLAN_PARALLEL resident_plan_par_kernel (S26's one-block parallel plan) is defined in verify_kernels.cu and in the SYCL port's verify_kernels.dp.cpp and launched in neither: resident_plan_kernel has grouped the entries in parallel since Niko1221#783 PR-e, and the port takes it since its re-migration to 0.1.40.1. nvcc reported it (Niko1221#177-D, declared but never referenced). docs/INTEL.md still offered STRATA_PLAN_PARALLEL=0, which no code reads any more. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NPNoLGUaVDVsDX9MSPPQgo
Owner
|
Thanks for the pull request. We're resetting the tracker for 0.2.0-beta. There are more than 1,300 open issues and pull requests, too many for us to review properly, so we're closing everything that isn't being worked on right now. Closed here does not mean rejected. To reopen it takes about two minutes:
The rules are in CONTRIBUTING.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two leftovers of the parallel resident plan. No behaviour change.
resident_plan_par_kernel(the one-block parallel plan from S26) is defined insrc/kernels/cuda/verify_kernels.cuand in the SYCL port'ssycl/src/kernels/cuda/verify_kernels.dp.cpp, and launched in neither:resident_plan_kernelhas grouped the entries in parallel since perf(cuda): fused decode/verify/MTP kernels and graph launch reductions on 0.1.39 #783 PR-e (the prefix scanresident_plan_paritychecks), and the port takes that kernel since its re-migration to 0.1.40.1. nvcc reports it:warning #177-D: function "resident_plan_par_kernel" was declared but never referenced.docs/INTEL.mdstill listsSTRATA_PLAN_PARALLEL=0among the switches to the old paths. No code reads it any more (it went with the port's own plan in the re-migration), so a user who sets it gets nothing.What changed
src/kernels/cuda/verify_kernels.cu:resident_plan_par_kerneland its comment removed (65 lines).sycl/src/kernels/cuda/verify_kernels.dp.cpp: the same function removed (90 lines).docs/INTEL.md:STRATA_PLAN_PARALLEL=0taken out of the switch list, with one sentence on why the plan has no switch.STRATA_GR_DOWN_DIRECTandSTRATA_MMVQ_WIDE_K, the other two on that line, are still read by the port.Checked
On 0.1.40.4, Windows (MSVC, CUDA 13):
stratabuilds, without the #177-D warning;resident_plan_parity: 641 cases, 0 failures.git grep resident_plan_par_kernelandgit grep STRATA_PLAN_PARALLELfind nothing afterwards. Not built with the SYCL toolchain (no oneAPI here); the removed function had no caller there either.🤖 Generated with Claude Code