Skip to content

verify: remove the unused resident_plan_par_kernel (CUDA and SYCL); INTEL.md no longer names STRATA_PLAN_PARALLEL - #1554

Closed
stuchapin909 wants to merge 1 commit into
Niko1221:mainfrom
stuchapin909:pr/plan-par-leftovers
Closed

stuchapin909 wants to merge 1 commit into
Niko1221:mainfrom
stuchapin909:pr/plan-par-leftovers

Conversation

@stuchapin909

Copy link
Copy Markdown
Contributor

Summary

Two leftovers of the parallel resident plan. No behaviour change.

  • resident_plan_par_kernel (the one-block parallel plan from S26) is defined in src/kernels/cuda/verify_kernels.cu and in the SYCL port's sycl/src/kernels/cuda/verify_kernels.dp.cpp, and launched in neither: resident_plan_kernel has grouped the entries in parallel since perf(cuda): fused decode/verify/MTP kernels and graph launch reductions on 0.1.39 #783 PR-e (the prefix scan resident_plan_parity checks), and the port takes that kernel since its re-migration to 0.1.40.1. nvcc reports it: warning #177-D: function "resident_plan_par_kernel" was declared but never referenced.
  • docs/INTEL.md still lists STRATA_PLAN_PARALLEL=0 among the switches to the old paths. No code reads it any more (it went with the port's own plan in the re-migration), so a user who sets it gets nothing.

What changed

  • src/kernels/cuda/verify_kernels.cu: resident_plan_par_kernel and its comment removed (65 lines).
  • sycl/src/kernels/cuda/verify_kernels.dp.cpp: the same function removed (90 lines).
  • docs/INTEL.md: STRATA_PLAN_PARALLEL=0 taken out of the switch list, with one sentence on why the plan has no switch. STRATA_GR_DOWN_DIRECT and STRATA_MMVQ_WIDE_K, the other two on that line, are still read by the port.

Checked

On 0.1.40.4, Windows (MSVC, CUDA 13): strata builds, without the #177-D warning; resident_plan_parity: 641 cases, 0 failures. git grep resident_plan_par_kernel and git grep STRATA_PLAN_PARALLEL find nothing afterwards. Not built with the SYCL toolchain (no oneAPI here); the removed function had no caller there either.

🤖 Generated with Claude Code

…NTEL.md no longer names STRATA_PLAN_PARALLEL

resident_plan_par_kernel (S26's one-block parallel plan) is defined in verify_kernels.cu and in the SYCL
port's verify_kernels.dp.cpp and launched in neither: resident_plan_kernel has grouped the entries in
parallel since Niko1221#783 PR-e, and the port takes it since its re-migration to 0.1.40.1. nvcc reported it
(Niko1221#177-D, declared but never referenced). docs/INTEL.md still offered STRATA_PLAN_PARALLEL=0, which no
code reads any more.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NPNoLGUaVDVsDX9MSPPQgo
@Niko1221

Copy link
Copy Markdown
Owner

Thanks for the pull request.

We're resetting the tracker for 0.2.0-beta. There are more than 1,300 open issues and pull requests, too many for us to review properly, so we're closing everything that isn't being worked on right now. Closed here does not mean rejected.

To reopen it takes about two minutes:

  1. Rebase on main if it no longer applies, and re-run your checks on 0.2.0-beta.
  2. Start the title with its area: [Engine], [GUI], [TUI], [Benchmark], [Docs] or [Other].
  3. Fill in the pull request template: the problem and result, and the validation (what you ran, on which revision, what you saw).
  4. Comment /reopen. A check runs and either reopens the pull request or lists what is still missing.

The rules are in CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants