Repository navigation
generate/verify: make diagnostic dumps work under --spec for native packs - #169
Closed
samuelishida wants to merge 1 commit into
Closed
samuelishida wants to merge 1 commit into
samuelishida wants to merge 1 commit into
Conversation
… under --spec A native (IQ) pack decodes through verify windows only, so the three oracle dumps must emit rows from those windows: - Capture the residual ladder inside the verify window graph when --dump-layers is set; rows are the fused-layout residual (layer l's write stays pending inside layer l+1's fused read), which is what the engine holds. - Write --dump-logits and --dump-final-r rows for accepted window rows only; rejected drafts are conditioned on tokens the ordinary path never feeds. - Rewrite the logits header at close with the real row count so readers see the size the file actually holds. - Refuse --dump-halves under --spec cleanly. - Decouple the expert-tier residency staging from the dump-gate so the table is available both to the token graph and to verify windows, while preserving the original gate for --no-capture / --no-token-graph paths. - Provision-gate ple_parity in CMake (its >100 MB fixtures and per-artifact oracle include were never committed); the missing supply chain is documented in tests/python/README.md. Also documents the native-pack dump semantics in docs/AMD_HIP.md.
Owner
|
Thanks @samuelishida, the dump block is now read-only and keeps the verify order, which was our main concern. Still needed for a new PR: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A native (IQ) pack decodes through verify windows only, so
--dump-logits,--dump-layers, and--dump-final-rmust emit rows from those windows rather than from the ordinary token loop.What this PR does:
--dump-layersis set. Rows are the fused-layout residual (layer l's write stays pending inside layer l+1's fused read), which is what the engine actually holds.--dump-logitsand--dump-final-rrows for accepted window rows only; rejected drafts are conditioned on tokens the ordinary path never feeds.--dump-halvesunder--speccleanly.--no-capture/--no-token-graphpaths.ple_parityin CMake because its >100 MB fixtures and per-artifact oracle include were never committed; the missing supply chain is documented intests/python/README.md.Also documents the native-pack dump semantics in
docs/AMD_HIP.md.