Skip to content

kv-grow: kvg_trim uploads the residency table with res_put, which waits for the copy #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sergqwer wants to merge 1 commit into from
Closed

kv-grow: kvg_trim uploads the residency table with res_put, which waits for the copy #1690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/program/generate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6046,8 +6046,8 @@ int main(int argc, char** argv) {
}
for (const auto& [i, s] : filled) host_res[i] = s;
kvg.refilled += (int64_t) filled.size();
if (cudaMemcpy(d_res, host_res.data(), host_res.size() * sizeof(int32_t), cudaMemcpyHostToDevice) != cudaSuccess)
return false;
// res_put waits for its copy: the next reader can be a verify window (a non-blocking stream) right away
if (res_put(d_res) != cudaSuccess) return false;
for (const strata::core::VmmChunk h : kvg.spare) strata::core::vmm_chunk_free(h); // new ones, if any
kvg.spare.clear();
++kvg.trims;
Expand Down