Skip to content

setup: an interrupted engine update is tried again instead of skipped for good (#2159) - #2161

Closed
ByteJuggler wants to merge 1 commit into
Niko1221:mainfrom
ByteJuggler:pr/engine-update-resume
Closed

ByteJuggler wants to merge 1 commit into
Niko1221:mainfrom
ByteJuggler:pr/engine-update-resume

Conversation

@ByteJuggler

@ByteJuggler ByteJuggler commented Oct 12, 2026 •

Copy link
Copy Markdown

Fixes #2159.

get_prebuilt moves BUILD.json to BUILD.json.prev before downloading, and update_installed_engine only puts it back if the process survives to its new is None branch. After a crash, reboot or closed window mid-update, every later update returned early on the missing BUILD.json, so the install stayed on its old engine without saying so.

Now, when BUILD.json is missing but BUILD.json.prev and the exe are there, the stamp is restored (with a warning) and the update runs again.

  • New test test_an_interrupted_update_is_tried_again (fails before the change, passes after).
  • tools/ suite: 3 failures in test_setup_engine_hash.WhatARefusalDoesToTheCaller, which fail the same way on main without this change.

@ByteJuggler
ByteJuggler force-pushed the pr/engine-update-resume branch from 8fda2a5 to f808495 Compare October 12, 2026 20:43
DamirLukina88 pushed a commit to DamirLukina88/D.L.-AI---Strata that referenced this pull request Oct 13, 2026
…is tried again instead of skipped for good (Niko1221#2159)

Source: Niko1221#2161

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DamirLukina88 pushed a commit to DamirLukina88/D.L.-AI---Strata that referenced this pull request Oct 13, 2026
…up robustness, conversation cache memory)

Serve: Niko1221#2290 Niko1221#2284 Niko1221#2285 Niko1221#2170 Niko1221#2140 Niko1221#2278. Setup: Niko1221#2161 Niko1221#2287. Engine: Niko1221#2253 Niko1221#2265 Niko1221#2247 Niko1221#2217 Niko1221#2243.
New opt-in engine flags: --session-state-codec (enabled in the local configs), --conversation-cache-park-gain and --drop-file-cache (left off: no measured benefit on the RX 7600 XT box). Bench: bench/results/upstream-prs-2026-10-13.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@qiuzan2001

Copy link
Copy Markdown

Checked on Linux: tools/test_setup_stale_stamp.py passes here and fails against main's setup.py, so the toolkit-13 case is fixed. The experimental CUDA 12 engine is still left out: the toolkit is None branch of update_installed_engine (setup.py:3090) visits engine-cuda12/ only when engine_dir(12) / "BUILD.json" exists, and after an interrupted update of that engine only BUILD.json.prev is there, so the new restore code is never reached for it. With both engine/ and engine-cuda12/ holding only an exe and BUILD.json.prev, engine/ gets its stamp back and engine-cuda12/ does not. Accepting BUILD.json.prev in that gate (and a toolkit-12 case in the test) would cover it.

…ipped for good (Niko1221#2159)

get_prebuilt moves BUILD.json aside before it downloads; when the process died before the failure branch put it
back (a crash, a reboot, a closed window), every later update_installed_engine returned early on the missing stamp
and the old engine stayed without a word. A leftover BUILD.json.prev beside the exe now goes back and the update
runs again.
@ByteJuggler
ByteJuggler force-pushed the pr/engine-update-resume branch from f808495 to bc80631 Compare October 17, 2026 10:51
@Niko1221

Copy link
Copy Markdown
Owner

Thanks for the pull request.

We're resetting the tracker for 0.2.0-beta. There are more than 1,300 open issues and pull requests, too many for us to review properly, so we're closing everything that isn't being worked on right now. Closed here does not mean rejected.

To reopen it takes about two minutes:

  1. Rebase on main if it no longer applies, and re-run your checks on 0.2.0-beta.
  2. Start the title with its area: [Engine], [GUI], [TUI], [Benchmark], [Docs] or [Other].
  3. Fill in the pull request template: the problem and result, and the validation (what you ran, on which revision, what you saw).
  4. Comment /reopen. A check runs and either reopens the pull request or lists what is still missing.

The rules are in CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An interrupted engine update leaves BUILD.json.prev and no BUILD.json; UPDATE.bat then skips the engine silently

3 participants