Repository navigation
Conversation
marcelloc
marked this pull request as ready for review
October 14, 2026 13:15
Owner
|
Thanks for the pull request. We're resetting the tracker for 0.2.0-beta. There are more than 1,300 open issues and pull requests, too many for us to review properly, so we're closing everything that isn't being worked on right now. Closed here does not mean rejected. To reopen it takes about two minutes:
The rules are in CONTRIBUTING.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Intel GPU monitoring on Windows via IGCL
Summary
Compatible with Strata 0.1.44.1, the upstream version used when preparing
this contribution (commit
296b59d2). The IGCL monitor was validated with thenative Windows SYCL server after integrating that release.
Populate the SYCL monitor's missing Intel GPU readings on Windows using an
optional native IGCL helper. The user explicitly builds/installs the helper;
inference continues without it when it is unavailable.
Related: #1940 and
#1390. This contribution can complement
their native Windows work; it does not include engine portability changes.
What changed
The helper uses the driver-installed ControlLib.dll. No vendor binaries or
headers are bundled. Shared CUDA/HIP server files are unchanged.
Validation
Windows 10 / Intel Arc Pro B70: helper build, actual API readings during
inference, parent-exit cleanup, collector and monitor unit tests, and JavaScript
label tests were exercised in the local implementation. The source files in
this contribution match that implementation. See docs/WINDOWS_INTEL_MONITOR.md.
Additional user-reported usage: code review with IQ3_XXS, MTP and a context
configured to 128K, with the server remaining up since the previous day.
This is practical usage evidence, not an instrumented soak test; it does not
establish that the conversation filled the entire 128K context window.
Extra Notes
Ready for review based on the Windows 10 / B70 validation above. Windows 11
and multi-GPU mapping remain untested; results can be added when available.
The IGCL collector is Windows-specific, but the integration also touches
sycl/serve/server_intel.py, which is shared with Linux. Linux regressionvalidation has not been performed. Maintainer or community help checking that
path is welcome; no Linux compatibility validation is claimed here.
Power is GPU chip power, not total board power. PCIe throughput is
unavailable and is not inferred from generation/width. A failed helper requires
server restart after the underlying issue is resolved.