Add generic config mechanism - #7
Conversation
|
Example implementation in the runner: Nitrokey/nitrokey-3-firmware#337 |
|
Looks good! |
3461dd6 to
a40f6a7
Compare
|
Main changes since the initial implementation:
Still, a case could be made to use a backend instead so that applications can access changed configuration values without reboot. Though that would mean that applications need to be aware of the configuration mechanism. |
|
pynitrokey PR for testing: Nitrokey/pynitrokey#448 |
For that, could the |
|
lgtm |
This patch adds a generic configuration mechanism to the admin app. There are two new commands, GET_CONFIG and SET_CONFIG, that can be used to query and change configuration values by key. The runner is responsible for providing the configuration struct and a mapping from key to field.
93fd1d2 to
5a8aedd
Compare
This patch adds a generic configuration mechanism to the admin app. There are two new commands, GET_CONFIG and SET_CONFIG, that can be used to query and change configuration values by key. The runner is responsible for providing the configuration struct and a mapping from key to field.
Points to discuss: