Repository navigation
chore(sync): absorb upstream main through b21d87243 (v0.0.36–v0.0.38 cycles) - #105
Merged
Merged
Conversation
…mproving launch times (pingdotgg#5769) Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@mac.lan>
…6011) Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
pingdotgg#8226) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius@mac.lan>
Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com>
…gdotgg#7313) Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@mac.lan>
Co-authored-by: Julius Marminge <julius@mac.lan>
Co-authored-by: Julius Marminge <julius@mac.lan>
Co-authored-by: Julius Marminge <julius@mac.lan>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
PRs pingdotgg#8437 and pingdotgg#8236 crossed: one made stashShortcutLabel a required ComposerStashMenu prop, the other added a test case without it, so main fails web typecheck. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
…dotgg#9013) Co-authored-by: Julius Marminge <julius@mac.lan>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…pingdotgg#9001) Co-authored-by: Guillermo Casanova <guillermo.casanova.b@gmail.com>
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
Six repeat contributors remained unvouched. Add their approved accounts to the trust list: - `github:ipanasenko` - `github:nateEc` - `github:maxwellyoung` - `github:tsouth89` - `github:0x4bs3nt` - `github:Adamulek123` This change does not modify runtime or workflow logic. Made by GPT-5.6 Sol in the Codex harness.
Absorbs upstream 018d7f2..b21d872 (v0.0.36–v0.0.38 cycles). Claude model handling follows upstream's remote-manifest discovery (pingdotgg#9084) instead of the fork's cherry-picked Fable 5.1 patch; the composer adopts ComposerSurface + ComposerBanner.Dock with the fork shell re-seated on top; the sidebar drops client-side auto-settle per pingdotgg#8600. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
The merge re-exposed several fork seams around upstream's banner dock and working row: - the prompt frame regained upstream's attached-banner glass (backdrop filter, drop shadow, ::after ring) for every banner except Questions; shed it unconditionally since the surface owns the fill and hairline - the Questions drawer kept ComposerBanner.Root's 4px inset on three sides; clear all padding, not only the bottom - the stash tab squeezed the full-width Questions card; the dock stacks and the tab rides above the card's right shoulder instead - "Preparing worktree..." rendered twice: upstream pingdotgg#8922 moved it into the timeline working row, so drop the composer control-row copy - the working-row rain sat baseline-aligned and gapless against the timer text after upstream's row rewrite; centre it with an 8px gap - the shell kept the mode/model row painted under the mobile pending-answer cluster, which upstream hides - BranchToolbar's no-thread branch reuses the liveness strip fallback instead of re-rendering it inline with a dead measure ref - drop the unused PencilRulerIcon import and a redundant guard clause Guards and manifest intents updated to pin each of these. Claude Fable 5.1 via Claude Code. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Absorbs 133 upstream commits (last sync point: 018d7f2, Aug 28) through b21d872 (Sep 1), spanning the v0.0.36–v0.0.38 release cycles. Notable arrivals: Claude Fable 5.1 (pingdotgg#9078) plus remote Claude model discovery (pingdotgg#9084), the composer banner dock (pingdotgg#8734, pingdotgg#8850, pingdotgg#8855), server-side thread settling (pingdotgg#8600, pingdotgg#8321, pingdotgg#8596), attaching any file to a turn (pingdotgg#8236) and video attachments (pingdotgg#8688), pull request list filters (pingdotgg#8809) and GitHub reference links in markdown (pingdotgg#8812), settings search by detail (pingdotgg#8831), keybinding settings rows (pingdotgg#8532), a searchable sidebar project filter (pingdotgg#5931), project settings from thread menus (pingdotgg#8925), the desktop quit-shortcut confirmation (pingdotgg#9076), the CLI opening projects in the running desktop app (pingdotgg#8824), Electron 43 (pingdotgg#8626), Expo SDK 57 (pingdotgg#8609), a run of server perf fixes (pingdotgg#8187, pingdotgg#8368, pingdotgg#9000, pingdotgg#9024, pingdotgg#9032, pingdotgg#8988), and remote web session cookie isolation (pingdotgg#8085).
Claude Fable 5.1 and the model manifest
The fork had cherry-picked upstream's Fable 5.1 commit (pingdotgg#9078, identical patch-id) in PR #103. Upstream then replaced the hard-coded Claude catalog with remote manifest discovery (pingdotgg#9084). All seven model/provider files in conflict (
ClaudeProvider.ts, the ClaudeAdapter and ProviderRegistry tests,ModelManifest.ts+model-manifest.json+ test,contracts/model.ts,shared/model.test.ts) resolve to upstream's version outright; the fork carries no customization there. Fable 5.1 and future Claude models now arrive through the remote manifest exactly as upstream ships it, and the fork's own Fable patch is gone.Resolution highlights
vp i, fork-only deps re-added).ComposerBanner.Dock(banner stack, sync/activity strip, approval/questions/plan drawer, tasks drawer and tab, stash badge) andComposerSurface.Main— with the fork shell re-seated on top:ComposerShellvessel, box/surface/drag-over markers, thepx-2 py-2.5prompt row,ComposerPromptRowcarrying send (now with upstream's attach-files paperclip ahead of it), "Ask anything", design-change pills, no bottom toolbar. The shoulder-clearance machinery is deleted: nothing hangs above the vessel any more. The banner stack and sync status therefore moved out of ChatView into the composer, as upstream did.ComposerSurface.Shell/Hostadopted; liveness stays on the context-strip pill (upstream's banner item is not rendered); the draft greeting stays on its own centered layer (upstream now parks it bottom-full above the stack); stray file-drop guard kept;ATTACHMENT_ONLY_BOOTSTRAP_PROMPTfor design-only sends.ComposerSurface.ContextStripadopted untouched;COMPOSER_CONTEXT_STRIP_CLASSNAMEdeleted and the fork's strip flatten re-keyed on[data-slot="composer-context-strip"]. The glass-shell disable rules are re-keyed on the composer-shell/host data-slots, since upstream deleted the CSS classes.[data-chat-composer-top-drawer]through the dock's two attachment wrappers. Upstream's fix(web): restore unified activity logs and composer banners pingdotgg/t3code#8734 restyle of its own card header is declined (the fork owns the card).settledOverrideis the only settle signal;changeRequestAutoSettlesis gone from client-runtime);confirmAndUnpinThread(feat(web): add toggleable confirmation before unpinning a thread pingdotgg/t3code#7313) adopted behind the draft-row guard; the project-settings context item (feat(web): open project settings from thread menus pingdotgg/t3code#8925) arrives. Upstream's searchable project combobox (feat(web): make the sidebar project filter a searchable combobox pingdotgg/t3code#5931) andfixedHeaderare declined per the manifest; the fork's scope row drives upstream's open-state reducer sohandleProjectSettingsstays upstream's.modelPickerModelHighlightsno longer exists upstream. The other four shadows were untouched upstream.session-logic.test.tstiming raise is retired; upstream fix(web): stop session activity timing test from blocking releases pingdotgg/t3code#8585 dropped that assertion.z-[60]now (fix(web): keep image preview above sidebar control pingdotgg/t3code#8811); guard and intent updated, the panel's z-45 sandwich still holds.DraftComposerAttachmentrename merged with the fork's checkout-branch import.Judgment calls to review
Verification
vp test run src/__fork_guards__— 45 files, 377 tests green.fork/lint-owned.mjsclean (193 files);vp fmt --checkclean on every hand-edited filesrc/custom+ model picker / composerProviderState / PendingUserInputPanel / MessagesTimeline / Sidebar logic and snooze / ChatHeader / BranchToolbar / ChatView logic tests — 78 files, 943 tests greengit rerererecorded all 17 resolutionsMerge and CI take the full suite from here.
Resolved by Claude Fable 5.1 via Claude Code.
🤖 Generated with Claude Code