feat(web): theme the orchestrator-V2 surfaces the sync left upstream-default

[NoahHendrickson]

Stacked on #169 (itself stacked on #167). Merge after both.

Problem

The V2 sync absorbed several new upstream surfaces exactly as upstream draws them: the thread details panel opened on upstream's 16px glass with a 22px radius beside the fork's frosted menus, subagent spawn batches rendered upstream's avatar-stack group (the fork's Figma tree had been parked), the liveness pill lost the per-task list upstream's dropped banner used to carry, and the sidebar sweep badge lit up in the primary tint next to the card's muted chips.

What this does

• Thread details panel — the inner data-thread-details-card joins the one popup frost rule (28px blur, --fork-popup-fill, 12% hairline) instead of being a surface of its own; it takes the composer vessel's radius, the fork's 4% row lift (upstream's hover utilities are !important, so the lift is too, stacking group + segment like upstream does) and the vessel hairline on section dividers. Toolbar pill marks stay off the panel rows.
• Subagent spawn batches — ForkSubagentGroup renders the Figma tree (t3-fork 376:21366) at the one call site: TreeView lead, "Kicked off / Ran N subagents", status summary with the batch's elapsed span, member rows with the sidebar's rain/dot marks, title, live activity or result, model ("Opus 5.5" from the slug) and elapsed. Fed from the thread's live subagent roster like upstream's group. V2 carries no effort or token usage per subagent and no agents panel, so the meta line is model + elapsed and a member row opens its own thread. Un-parks fork-subagent-spawn-card; upstream's V2SubagentGroup stays in the file for the next sync.
• Liveness pill — the count is a button that opens a frosted popover naming each pending task; a subagent's row opens its thread. Stop keeps its place.
• Sweep badge — data-fork-sweep-badge takes the card's chip fill, pill hairline and radius.

Manifest and guards updated for each (fork-popup-surface, fork-subagent-spawn-card, fork-composer-shell, sidebar-v2-row-action-hit-area).

Verified

• web typecheck 0 errors; fork guards 495/495; custom tests 229; .fork/lint-owned.mjs clean
• Browser (Glass palette, seeded worktree server): thread details panel before/after and row hover; the spawn tree on a seeded two-subagent batch; a live sweep showing the badge. Screenshots are in ~/.t3-fork/userdata/attachments/fork-v2-surface-theming/ for the PR (gh cannot upload images).
• Not visually verified: the pill's task popover (the shell's pending-task roster is precomputed server-side and could not be seeded) and the queued-runs control / provider subagent bar (need a live run). Both already sit on fork surfaces; worth a look on a real run after merge.

Claude Fable 5.1 via Claude Code (T3 Code).

🤖 Generated with Claude Code

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

⚠️ The thread fixture changed, so impact percentages are not directly comparable to the main baseline.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	—	5.0 KiB	—	6.8 KiB	✅
Codex	Thread snapshot wire	—	3.8 KiB	—	4.9 KiB	✅
Codex	Live turn WebSocket wire	—	1.2 KiB	—	2.0 KiB	✅
Codex	Live turn WebSocket decoded	—	20.9 KiB	—	29.3 KiB	✅
Codex	Live turn messages	—	2	—	8	✅
Claude	Total thread wire	—	5.0 KiB	—	6.8 KiB	✅
Claude	Thread snapshot wire	—	3.8 KiB	—	4.9 KiB	✅
Claude	Live turn WebSocket wire	—	1.2 KiB	—	2.0 KiB	✅
Claude	Live turn WebSocket decoded	—	21.2 KiB	—	29.3 KiB	✅
Claude	Live turn messages	—	2	—	8	✅

Baseline: ef5d6a9 · PR result: fe0fa05 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[cursor]

Stale comment

Thermo-nuclear review: do not approve.

The tree belongs in custom/ and correctly reuses subagentGroupSummary / summarizeSubagentStatuses. The rest of the PR stands up a second subagent-display pipeline and a second background-work DTO beside helpers that already do this work. That is a structural regression, not a presentation layer.

Keeping unused V2SubagentGroup behind the oxlint disable is the documented sync tactic — not a finding. Do not decompose theme.custom.css / ChatView / the yaml for these adds.

Blockers

1. forkSubagentTree is a parallel pipeline. Settled-status, progress/result pick, markdown strip, ISO round-trip, slug spelling, and batch timing are re-derived next to isTerminalSubagentStatus, subagentDetailPreview, formatModelSlugName, V2LifecycleRow's plainDetail / GENERIC_CHILD_END, and subagentGroupTiming. Two copies will drift the first time upstream tweaks any of those. Keep Figma chrome in ForkSubagentGroup; shrink the model to a live-roster join plus the existing helpers. STATUS_MARK is the one fork-owned table that should stay.

2. ChatView maps a clone of PendingBackgroundWorkItem. The composer-shell comment says assembly lives in composerContextStrip, then ChatView (already ~12k) builds a looser DTO (kind: string, optional tasks / onOpenThread, conditional spreads) for a single call site that always has items and a navigator. presentPendingBackgroundWork never returns an empty list. Pass presentation through; delete ComposerBackgroundLivenessTask. The new guard pins the .map, so the bad shape is now a sync invariant.

Also fix

• Timestamp round-trip (DateTime → ISO → Date.parse → ISO) and liveness encoded twice (mark === "rain" vs group.active).
• Thread-details hover keys on [class*="group/thread-details-"] plus a blanket button:hover !important. Same class of smell as #167's .h-auto pin: Tailwind internals, not a data stamp. The sweep badge in this PR already does the right thing (data-fork-sweep-badge).
• Stopped members skip SidebarV2StatusIndicator for a one-off 8px fill. Route stopped through the existing mark set.

  

_{Sent by Cursor Automation: Thermo nuke 4.6}

[NoahHendrickson]

Reviewed at 1cd2058, including its integration with the latest #167. Changes needed.

[P1] Restore the status-dot export when updating the stack. ForkSubagentGroup.tsx:40

This imports SidebarV2StatusDot, but #167's later d6fe721 cleanup removes that export from SidebarV2StatusIndicator.tsx. This branch was cut before that cleanup and does not change the indicator file. A clean merge with #167 at 78b5c2e therefore leaves this import pointing at a private function. I reproduced the combined tree with git merge-tree and ran a focused Rolldown bundle of the two resulting modules: it fails with MISSING_EXPORT for SidebarV2StatusDot. Rebase/update onto the current base and restore the export or use the public indicator API before merging; the earlier green typecheck/build does not cover this combined tree.

[P2] Update the timeline behavior tests alongside the replacement renderer. MessagesTimeline.tsx:2828

ForkSubagentGroup always renders its members, but six existing MessagesTimeline cases still expect the group to start collapsed and then click its disclosure. All six fail at MessagesTimeline.test.tsx:2111 (expected 0 member buttons, got 2), so this PR's Test Web check remains blocked even after bringing in the base's unrelated CI fixes. Update those cases to exercise the intended always-visible tree, preserving checks for live/completed/cancelled detail and child-thread navigation.

Validation: the focused forkSubagentTree + MessagesTimeline run has 82 passing tests and these 6 failures. I traced the other CI failures (knip's ThreadContextDragGhost, sidebar-width/settings tests, Windows profile fixture) to the older #167 base; its later fixes address those separately. No browser verification.

[NoahHendrickson]

Review: #168 V2 surface theming

Verdict: not mergeable yet. CI is red for two separate reasons, and three of the new rules/helpers misbehave on real data. The structure is mostly right (the tree lives in custom/, reuses subagentGroupSummary / summarizeSubagentStatuses, and the Figma chrome is cleanly separated), so this is a fix-up round, not a redo.

Blockers

1. Branch is behind its base. This branch forks off 82a31f8, before #167's two follow-up commits (d6fe721 knip ignores + the two upstream tests, 78b5c2e Windows profile test). That is the ThreadContextDragGhost.tsx knip failure and the SettingsPanels.restore / threadSidebarWidth failures in CI. Merge origin/claude/sync-2026-10-05 in (or rebase). I reproduced all three locally on this head and they are not from your change.

2. Six upstream MessagesTimeline.test.tsx cases fail on the swap itself. shows 2 {running,completed,cancelled} subagents … grouping only multiple agents (6 cases) look for upstream's group button (aria-label="2 subagents") and expect the member buttons to be hidden until it is clicked; the fork tree renders the Open Package audit buttons immediately, so expect(child()).toHaveLength(0) at line 2111 fails. Reproduced locally: 6 failed / 270 passed in that file. These need fork-fenced adjustments in the test (the convention #167 already uses in the same file) or a fork variant, plus the manifest watch: entry.

3. The thread-details hover rule wipes the automation Switch's checked fill. theme.custom.css:2627-2636 puts background-color: … !important on every button:hover inside [data-thread-details-card]. ThreadAutomationsPanel (mounted inside the card at ThreadDetailsPanel.tsx:226) renders a base-ui <Switch>, which is a <button role="switch"> whose track is data-checked:bg-primary; the !important beats the utility, so hovering an enabled automation turns its track into the 4% wash and it reads as off. Scope the rule to the row/action wrappers or exclude [role="switch"]. Cursor's point about keying on group/thread-details-* class substrings stands too: a data stamp is the fork's own convention (the sweep badge in this PR does it right).

4. The pill label button inherits the context-row chip hover fill. ComposerShell.css:108 resets background: transparent on button[data-fork-monitoring-list] at specificity (0,4,1), but theme.custom.css:1072-1079 ([data-fork-composer-context-row] :is(button, …):is(:hover, [data-pressed], [data-popup-open]):not(:disabled)) is (0,5,1) and wins. Hovering "2 agents", and the whole time the popover is open, paints a 24px zero-padding chip-hover block inside the pill, the exact artifact the stop button's own comment in this file guards against. Give the list button its own :hover/[data-popup-open] rule the way the stop button does.

5. formatForkSubagentModel mangles the ids Claude subagents actually report. For Claude, task.model is the API's dated snapshot id (ClaudeAdapterV2.ts:5823, message.message.model). Running the formatter on those:

   slug	fork	formatModelSlugName
   claude-sonnet-4-5-20250929	Sonnet 4.5.20250929	Claude Sonnet 4.5 20250929
   claude-opus-4-6[1m]	Opus 4 6[1m]	Claude Opus 4.6[1m]
   claude-opus-5-5	Opus 5.5	Claude Opus 5.5

   The "join every consecutive numeric part with a dot" rule treats the date as a third version segment. Reuse formatModelSlugName from @t3tools/shared/model and strip the vendor word, or go through the catalog like upstream's resolveSubagentMetadata does (it never shows the date).

Agree with Cursor on reuse, with specifics

• isForkSubagentSettled is isTerminalSubagentStatus (client-runtime/state/subagentRuntime.ts:84) over the same literal union; delete it.
• resolveDetail's progress/result preference is subagentDetailPreview (client-runtime/state/subagentDisplay.ts:121), already exported. Call it, then apply the fork-only GENERIC_CHILD_END fallback and the markdown strip on its output.
• resolveBatchTiming re-encodes liveness as mark === "rain" while tree.active already says it, and round-trips DateTime → ISO → Date.parse → ISO. Compute from tree.active and the row timestamps once.
• ComposerBackgroundLivenessTask / optional tasks + onOpenThread: presentPendingBackgroundWork never yields an empty roster, so the label-only fallback at ComposerMonitoringPill.tsx:88-99 is dead code and the conditional spreads in composerContextStrip.tsx cover a missing pass-through. Pass presentation.items and a required onOpenThread; drop the clone type.
• Keep STATUS_MARK; that is the fork's vocabulary.

Nits

• ComposerMonitoringPill.tsx:74-78: role="status" now always sits inside the trigger <button> (see dead fallback above). Children of role=button are presentational, so the "Stopping…" announcement the live region existed for is dropped. Put the live region on a sibling.
• ComposerMonitoringPill.tsx:101: <PopoverPopup className="w-64 p-1"> restyles a components/ui export; width="sm" and padding="compact" are the knobs, and p-1 leaves the inner Viewport's default 16px inset in place anyway. Lint is off for src/custom, so CI won't say this.
• ForkSubagentGroup.tsx:66: aria-label on a role-less <div> is prohibited (axe aria-prohibited-attr); upstream had it on the collapsible trigger button.
• Sidebar.tsx:1468: the new data-fork-sweep-badge stamp is inside an existing fence, but sidebarV2RowActionHitArea.test.ts never mentions it and the manifest entry's files don't list theme.custom.css. A sync that drops the attribute reverts the badge to the --primary tint with no red test.
• Manifest/body: the subagent entry says the batch's elapsed span rides the header; resolveBatchTiming returns null whenever no row has startedAt, which is the common provider-native case, so the header often has no span. Fine, just state it.

Verified fine

• Roster join on agent.id === item.subagentId matches V2SubagentGroup and SubagentTimelineLink; every field the tree reads exists with that type; useAtomValue(atom, selector) is the overload upstream uses at MessagesTimeline.tsx:3060, same subscription granularity as upstream's group.
• onOpenRelatedThread is a stable useCallback; the useMemo deps are complete; the pill is a direct child of ComposerSurface.ContextStrip, not nested in a button; Stop sits outside the Popover.
• Settled set, detail preference, and batch timing rules match upstream's today (the duplication is a drift risk, not a current bug).
• Fork guards 495/495, forkSubagentTree.test.ts passes, .fork/lint-owned.mjs clean on this head. git merge-tree of this branch with #169's is conflict-free.

Merge mechanics

Retarget to custom with gh pr edit 168 --base custom before #167 merges.

Reviewed by Claude Fable 5.1 via Claude Code (T3 Code); every finding re-verified against the source on a detached checkout of 1cd2058.

[NoahHendrickson]

button:hover + !important here also hits the base-ui <Switch> (<button role="switch">) that ThreadAutomationsPanel renders inside this card (ThreadDetailsPanel.tsx:226). Its track is data-checked:bg-primary; this rule overrides it on hover, so an enabled automation reads as off while the pointer is over it. Scope to the row/action wrappers (a data stamp, as the sweep badge below does) or add :not([role="switch"]).

[NoahHendrickson]

Specificity: this reset is (0,4,1), but theme.custom.css:1072-1079 ([data-fork-composer-context-row] :is(button, …):is(:hover, [data-pressed], [data-popup-open]):not(:disabled)) is (0,5,1) and wins. Hovering the label, and the whole time the popover is open, paints the chip-hover fill as a 24px zero-padding block inside the pill. The stop button in this file avoids it with its own :hover:not(:disabled) rule; this button needs the same for :hover and [data-popup-open].

[NoahHendrickson]

Claude subagents report dated snapshot ids (ClaudeAdapterV2.ts:5823 stores message.message.model): claude-sonnet-4-5-20250929 → Sonnet 4.5.20250929, claude-opus-4-6[1m] → Opus 4 6[1m] (ran the function on both). The dot-join treats the date as a version segment. formatModelSlugName from @t3tools/shared/model already yields "Claude Opus 5.5"; strip the vendor word from that instead of a second parser.

[NoahHendrickson]

This is isTerminalSubagentStatus (packages/client-runtime/src/state/subagentRuntime.ts:84) over the same union, and resolveDetail below is subagentDetailPreview (subagentDisplay.ts:121) plus the fork's GENERIC_CHILD_END / markdown strip. Import both and keep only the strip here; the export is also unused outside this file.

[NoahHendrickson]

tasks is non-empty whenever the pill renders (presentPendingBackgroundWork returns null for zero items and ChatView maps every item), so the labelNode-only branch below is dead and this role="status" always ends up inside the trigger <button>. Children of a button are presentational, so the "Stopping…" announcement is dropped. Move the live region to a sibling and make tasks/onOpenThread required.

[NoahHendrickson]

className="w-64 p-1" restyles a components/ui export (the no-restyle rule; lint is off for src/custom, so nothing flags it). width="sm" / padding="compact" are the knobs, and p-1 lands on the Popup while the inner Viewport keeps its default 16px inset, so the 6px rows sit inside a prose inset anyway.

[NoahHendrickson]

aria-label on a role-less <div> is prohibited (ARIA 1.2, axe aria-prohibited-attr). Upstream had it on the collapsible trigger button; here either give the container a role (group) or drop the label.

[NoahHendrickson]

tree.active already says whether the batch is live; mark === "rain" re-derives it from the sidebar vocabulary. And this round-trips DateTime → ISO (isoOrNull) → Date.parse → ISO. Compute the span once from tree.active and the row timestamps, and note that with no startedAt on any row (the usual provider-native case) the header gets no span at all.

[NoahHendrickson]

The stamp is fenced, but nothing pins it: sidebarV2RowActionHitArea.test.ts never mentions data-fork-sweep-badge and the manifest entry's files don't list theme.custom.css. A sync that drops this attribute reverts the badge to the --primary tint with CI green.

[NoahHendrickson]

Agree with Cursor here: this maps PendingBackgroundWorkItem into a looser clone for one caller that always has a roster and a navigator. Pass presentation.items and onOpenRelatedThread through to resolveComposerLivenessPillProps and let it (or the pill) read taskId/label/kind/childThreadId directly; then the new guard can pin that instead of the .map.

[NoahHendrickson]

Addressed at fe0fa05, after rebasing onto #169's branch (claude/sync-2026-10-07) and retargeting there, so #167's CI fixes and the SidebarV2StatusDot change are in the base. Notes by path.

Blockers

1. Branch behind its base: rebased; the knip, SettingsPanels.restore and threadSidebarWidth failures are gone with it.
2. MessagesTimeline.test.tsx: the six grouped-batch cases no longer click a collapsed group open (fenced fork-subagent-spawn-card); they still check member rows, detail text and child-thread navigation. 62 files / 589 tests pass with the guards.
3. theme.custom.css thread-details lift: keys on .fork-thread-details-lift, a hook fenced onto upstream's one hover-surface class string in threadDetailsPanelStyles.ts (every panel row, split half and icon action composes it), so the automations Switch is untouched and no Tailwind group name or blanket button:hover is a contract. forkPopupSurface.test.ts pins the hook, the rule and the absence of both smells.
4. ComposerShell.css: the label button has its own :is(:hover, [data-pressed], [data-popup-open]):not(:disabled) rule at a higher specificity than the chip-hover rule, holding transparent.
5. forkSubagentTree.ts model: formatModelSlugName with the vendor word dropped and the snapshot date left off — claude-sonnet-4-5-20250929 reads "Sonnet 4.5", claude-opus-4-6[1m] "Opus 4.6[1m]", gpt-6-astra upstream's "GPT-6-Astra". Unit test covers each.

Reuse (Cursor + review)

• isForkSubagentSettled deleted; resolveDetail is subagentDetailPreview then the fork's placeholder drop and markdown strip.
• Batch timing is computed once in the model from the DateTime values and subagentGroupSummary's active, no ISO round-trip, no mark === "rain"; the component reads tree.timing.
• ComposerBackgroundLivenessTask is gone: the pill takes PendingBackgroundWorkItem as is, ChatView passes presentation and resolveComposerLivenessPillProps derives liveness, count and the list; tasks and onOpenThread are required and the label-only branch is deleted.
• Stopped members go through SidebarV2StatusMark (idle circle), as do rain, done and failed; no private import.
• STATUS_MARK stays.

Nits

• Live region is a sibling of the trigger; the visible label inside the button is aria-hidden.
• <PopoverPopup width="sm" padding="compact">.
• The tree's container is role="group" with the lead as its label.
• sidebarV2RowActionHitArea.test.ts pins data-fork-sweep-badge and the chip rule; the manifest lists theme.custom.css under that entry, threadDetailsPanelStyles.ts under fork-popup-surface, and MessagesTimeline.test.tsx under the spawn card, and says the header span only exists when a member reports a start time.

Verified locally: web typecheck clean; fork guards + forkSubagentTree.test.ts + MessagesTimeline.test.tsx 589/589; lint on touched files (only the pre-existing ChatView baseline warnings), lint-owned and knip clean. Not browser-verified. GitHub Actions has created no runs on this repo since Oct 9 02:16 UTC, so the checks here stay pending until that is sorted.

[cursor]

Thermo-nuclear review at fe0fa05: approve. No major structural issues.

The skill bar is met: no structural regression, no leftover canonical-helper clone, no 1k crossing, no spaghetti at the fenced call sites. The three blockers from the earlier HEAD are gone.

• forkSubagentTree joins the live roster and calls subagentDetailPreview / subagentGroupSummary / summarizeSubagentStatuses / formatModelSlugName. STATUS_MARK, the local GENERIC_CHILD_END + plainDetail strip after the preview, and batch timing from DateTime + group.active stay as the requested fork shape — not a second display pipeline.
• ChatView only passes presentation + onOpenThread. The pill reads PendingBackgroundWorkItem directly; the clone DTO is gone.
• Thread-details hover keys on fork-thread-details-lift stamped on the shared hover-surface string, not [class*="group/thread-details-"] or blanket button:hover. The automations Switch is out of the selector.

Unused V2SubagentGroup remains the sync tactic. Do not decompose theme.custom.css / ChatView / MessagesTimeline / yaml for this add.

  

_{Sent by Cursor Automation: Thermo nuke 4.6}