Skip to content

Give the agent's context-assembly search an explicit scope #3577

Closed

Description

@mstomar125

Problem

packages/agent/src/agent_catalog/context_assembly.rs:329 calls semantic_search_nodes(.., None, ..) with no scope. Its neighbour expansion already picked up skills and tools. Since every core schema is now embedded (#3538, 4aad201f), it can also pick up core schemas ("Checkbox", "Horizontal Line"…) as context for a local-agent turn.

Found while fixing #3565, which handles the user-facing untyped search. This call site is in packages/agent, so it's left for that package's owner.

Documentation

Acceptance criteria

  • Context assembly searches with an explicit scope that matches what it means to retrieve, and core schemas appear only when intended.
  • A test pins it.

🤖 Generated with Claude Code

Activity

  1. mstomar125 commented on Oct 5, 2026

    @mstomar125
    ContributorAuthor

    Related, also in packages/agent: src/local_agent/tools.rs:1089 describes the knowledge scope as "text/header/code/schema nodes". That was already out of date, and after #3576 built-in schemas are also left out of that scope (user-defined schemas stay). Worth updating together with this issue.

    🤖 Generated with Claude Code

  2. malibio commented on Oct 5, 2026

    @malibio
    Collaborator

    This file is scheduled for deletion, so I'd suggest closing this in favour of #3547 rather than fixing the call.

    If something does need scoping before #3547 lands, that would be worth saying here; otherwise there is nothing reachable to fix.

  3. malibio commented on Oct 5, 2026

    @malibio
    Collaborator

    Baseline — Frontend: 318 test files passed, 5770 tests passed

  4. self-assigned this
    on Oct 5, 2026
  5. added a commit that references this issue on Oct 5, 2026
    b235c11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions