Remove parent_id/container_node_id from Node API - Full Graph Migration

Summary

Complete the graph-native architecture migration by removing parent_id and container_node_id fields from the Node model and all API responses. Currently, these fields are populated for backward compatibility (Issue #511 partial implementation), but they should be removed to fully leverage SurrealDB's graph capabilities.

Background

Issue #511 migrated NodeSpace to a graph-native architecture using SurrealDB:

• ✅ Database layer uses graph edges (has_child) for hierarchy
• ✅ No parent_id/container_node_id stored in database tables
• ⚠️ Temporary workaround: get_children() reconstructs these fields from query context for frontend compatibility

Current State (packages/core/src/db/surreal_store.rs:1307-1314):

// Populate parent_id and container_node_id for frontend compatibility
// In graph architecture, these are derived from the query context, not stored
if let Some(pid) = parent_id_value {
    for node in &mut nodes {
        node.parent_id = Some(pid.clone());
        node.container_node_id = Some(pid.clone());
    }
}

This is a temporary bridge - not the elegant graph-native solution.

Problem

The current approach has several issues:

1. Incomplete graph migration: Backend uses graphs, but API still exposes flat parent_id fields
2. Inconsistent data model: Node struct has fields that don't exist in database
3. Coupling: Backend reconstructs data to match old frontend expectations
4. Performance: Requires extra logic to populate fields that shouldn't exist
5. Missing hierarchy info: Frontend only knows immediate parent, not full ancestor chain (graphs enable this)

Proposed Solution

Phase 1: Backend Cleanup (Rust)

1. Remove fields from Node struct (packages/core/src/models.rs):

   pub struct Node {
       pub id: String,
       pub node_type: String,
       pub content: String,
       // REMOVE: pub parent_id: Option<String>,
       // REMOVE: pub container_node_id: Option<String>,
       pub before_sibling_id: Option<String>,
       // ... rest of fields
   }

2. Remove field population (packages/core/src/db/surreal_store.rs:1307-1314):

   • Delete the parent_id/container_node_id reconstruction code in get_children()
   • Remove from From<SurrealNode> for Node conversion (already hardcoded to None)

3. Update CreateNodeRequest (packages/desktop-app/src-tauri/src/bin/dev-proxy.rs:246):

   • Remove parent_id and container_node_id fields from request struct
   • API should accept only parentId in request body, use it for edge creation, then discard

Phase 2: Frontend Migration (TypeScript/Svelte)

1. Update Node interface (packages/desktop-app/src/lib/models/node.ts):

   export interface Node {
       id: string;
       nodeType: string;
       content: string;
       // REMOVE: parentId?: string | null;
       // REMOVE: containerNodeId?: string | null;
       beforeSiblingId?: string | null;
       // ... rest of fields
   }

2. Update components to use context instead of node.parentId:

   • Components receiving nodes from getNodesByContainer(parentId) already know the parent
   • Pass parent context via component props or Svelte context API
   • Example: <BaseNodeViewer {nodes} parentId={currentPageId} />

3. Key files to update:

   • src/lib/services/backend-adapter.ts - Remove field mapping
   • src/lib/design/components/base-node-viewer.svelte - Accept parent via prop
   • src/lib/components/viewers/date-node-viewer.svelte - Pass parent context
   • Any component using node.parentId or node.containerNodeId

Phase 3: Enhanced Graph Features (Future)

Once fields are removed, we can add graph-native features:

1. Ancestor chains: GET /api/nodes/:id/ancestors - full parent hierarchy
2. Descendant trees: GET /api/nodes/:id/descendants?depth=N - subtree queries
3. Sibling queries: GET /api/nodes/:id/siblings - nodes with same parent
4. Graph traversal: Complex queries like "all tasks under this project, 3 levels deep"

Implementation Guide

Step 1: Search and Replace

Find all usages of these fields:

# Backend (Rust)
rg "parent_id|container_node_id" packages/core/
rg "parent_id|container_node_id" packages/desktop-app/src-tauri/

# Frontend (TypeScript/Svelte)
rg "parentId|containerNodeId" packages/desktop-app/src/

Step 2: Update Each Usage

For each usage, determine:

• If creating a node: Keep parentId in request body for edge creation only
• If reading a node: Replace with parent context from component hierarchy
• If checking hierarchy: Use new graph query endpoints (Phase 3)

Step 3: Testing Strategy

1. Unit tests: Update Node model tests to remove field assertions
2. Integration tests: Verify edge creation still works without returning parent_id
3. UI tests: Ensure components render correctly with context-based parents
4. Manual testing:
   • Create nodes under date pages
   • Convert text → task (type changes preserve hierarchy)
   • Verify tasks appear in correct containers
   • Check backlinks and mentions still work

Example: Component Migration

Before (using node.parentId):

<script>
    export let node: Node;

    // Component has no idea what the parent is unless node.parentId exists
    $: hasParent = !!node.parentId;
</script>

After (using context):

<script>
    export let node: Node;
    export let parentId: string | null = null;  // Passed from parent component

    // Parent context is explicit, not embedded in node data
    $: hasParent = !!parentId;
</script>

Acceptance Criteria

• parent_id and container_node_id fields removed from Node struct (Rust)
• parentId and containerNodeId fields removed from Node interface (TypeScript)
• Backend get_children() no longer populates these fields
• All frontend components use parent context instead of node.parentId
• Node creation still creates has_child edges correctly
• UI correctly displays tasks under date pages
• Type conversion (text → task) preserves hierarchy
• All tests pass
• No regression in node creation, editing, or hierarchy display

Technical Notes

• The Node model is used across Rust backend, Tauri bindings, and TypeScript frontend
• Changes must be coordinated across all three layers
• Parent context is already available in components via getNodesByContainer(parentId) calls
• This is a cleanup/refactor, not a feature - behavior should remain identical from user perspective

Estimated Effort

• Backend changes: 1-2 hours (straightforward field removal)
• Frontend changes: 3-4 hours (updating component patterns)
• Testing: 2 hours (integration and manual testing)
• Total: ~6-8 hours for a junior engineer with guidance

References

• Issue SurrealDB Schema Refactor: Graph-Native Architecture #511: SurrealDB graph-native architecture migration
• File: packages/core/src/db/surreal_store.rs:1307-1314 - Temporary workaround to remove
• File: packages/core/src/db/surreal_store.rs:166-167 - Hardcoded None in conversion
• Documentation: SurrealDB graph relations - https://surrealdb.com/docs/surrealql/statements/relate