Repository navigation
Refuse schema names whose derived id is a date (#3674) - #3678
Merged
Merged
Conversation
Collaborator
Author
Code Review SummarySmall, well-scoped change (3 files, +40/-1) that does exactly what #3674 asks. The check sits beside the core-type check in Acceptance criteria
FindingsCritical IssuesNone. Suggested ImprovementsNone blocking. Nitpicks
RecommendationAPPROVE. Run |
malibio
commented
Oct 7, 2026
malibio
left a comment
Collaborator
Author
There was a problem hiding this comment.
Automated pragmatic-code-review: APPROVE (posted as a comment — GitHub blocks self-approval).
Collaborator
Author
|
Addressed the one nit (comment in the test). Skipped none else; reviewer noted the calendar-validity behaviour of the predicate needs no change. Comment-only change, no re-review needed. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
malibio
force-pushed
the
issue-3674-schema-date-id
branch
from
October 7, 2026 08:40
6eed7b8 to
06b6e5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_schema now refuses a name whose derived id is a valid YYYY-MM-DD date (e.g. "2026-10-06", "2026_10_06", "2026 10 06"), reusing the date node's id predicate. The check runs beside the core-type check, before any write. Digit-bearing names ("Invoice 2026", "Q4-2026") remain accepted.
Closes #3674
🤖 Generated with Claude Code