[malibio]

The routing scenario instance-not-schema-invoice is about feature specs ("Add a spec for offline sync…"); only its id still said invoice. Renamed to instance-not-schema-spec in the fixture and its test.

Other invoice mentions were checked and left: the skill-retrieval goldens score real invoice prompts, and the decision/runner/graph tests use invoice as a sample type id in fixture data. None is a stale name.

Issue #3666's reproduction command uses the old id and is updated separately.

🤖 Generated with Claude Code

[malibio]

Code Review Summary

Verdict: APPROVE (posted as a comment because self-approval is blocked). No findings.

This is a two-line rename of the routing eval scenario id instance-not-schema-invoice to instance-not-schema-spec. It has one purpose and is atomic. The scenario text is about a feature spec ("add a spec for offline sync"), so the new id matches the content.

• A grep for instance-not-schema across the branch, excluding node_modules, target and .git, finds exactly the two edited lines: the fixture id in scripts/eval/fixtures/routing.ts and the byId(...) lookup in routing.test.ts.
• The old id has no remaining references in scripts, package.json, packages or nodespace-docs, and no saved results carry it.
• The only other place the old id appears is the primary checkout, which is still on the pre-merge main. That is expected.
• The test uses byId, so a missed rename would fail loudly rather than silently pass.
• Leaving the other invoice mentions alone (retrieval goldens, sample type ids) is the right call. They are separate concerns and renaming them here would break atomicity.

No Critical issues, no Improvements, no Nits.

[malibio]

Code Review Summary

Verdict: APPROVE (posted as a comment because self-approval is blocked). No findings.

This is a two-line rename of the routing eval scenario id instance-not-schema-invoice to instance-not-schema-spec. It has one purpose and is atomic. The scenario text is about a feature spec ("add a spec for offline sync"), so the new id matches the content.

• A grep for instance-not-schema across the branch, excluding node_modules, target and .git, finds exactly the two edited lines: the fixture id in scripts/eval/fixtures/routing.ts and the byId(...) lookup in routing.test.ts.
• The old id has no remaining references in scripts, package.json, packages or nodespace-docs, and no saved results carry it.
• The only other place the old id appears is the primary checkout, which is still on the pre-merge main. That is expected.
• The test uses byId, so a missed rename would fail loudly rather than silently pass.
• Leaving the other invoice mentions alone (retrieval goldens, sample type ids) is the right call. They are separate concerns and renaming them here would break atomicity.

No Critical issues, no Improvements, no Nits.

[malibio]

Address-review: the review (APPROVE) had no findings, so nothing was changed and nothing skipped.

Re-Review Decision

Decision: NO RE-REVIEW NEEDED

Rationale: No commits since the review; the PR is the two-line rename it was reviewed as.