Repository navigation
Remove the Available remote models list from Settings (closes #3696) - #3703
Conversation
|
Added the ai-chat titler fix to this PR: the titling budget goes from 48 to 512 tokens (a reasoning model needed ~165 thinking tokens and returned no title at 48), and an empty or failed title attempt now logs a warning instead of nothing. New test simulates a reasoning model; it fails at 48 and passes at 512. Not merging yet, per the plan to fold in more fixes. |
Code Review SummaryNet positive. Both commits are small and correct. Removing the "Available remote models" list matches issue #3696 (the selector and default dropdown are per-provider, discovered models are suggestions only). The titler change fixes a real silent failure, and the new test is a good invariant-style regression. Verdict: approve-equivalent, one small Improvement below. FindingsCritical IssuesNone. Suggested Improvements
Nitpicks
Checklist
|
malibio
left a comment
There was a problem hiding this comment.
Review posted above: net positive, no blockers. One small Improvement (restore buildDefaultOptions on the loadProviders failure path); the rest are nits. Fine to merge once addressed or consciously skipped.
|
Addressed review: moved buildDefaultOptions() after the try/catch in onMount so the default-model dropdown builds even if the provider read fails; merged the two rationales in the TITLE_MAX_TOKENS comment (1e62820). Skipped: newline stop sequence for the titler (a preamble line would cut the title off; the extra budget is only spent by models that think) and the Ollama URL hint (dropped on purpose with the list). Frontend tests: 5873 passed. Not merging yet. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…en it yields no title (refs #3696) At 48 tokens a served reasoning model finished with no answer text, so the chat stayed Untitled and the log said nothing. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ad fails; tidy titler budget comment (refs #3696) Skipped: newline stop sequence for the titler (a preamble line would cut the title off; the headroom is only spent by models that think), and the Ollama URL hint (dropped on purpose with the list). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
1e62820 to
131e9b9
Compare
Settings → AI Models listed every model each endpoint discovers (hundreds for OpenRouter), above the provider entries. A provider is one endpoint plus one model, and the Model field now suggests discovered models, so the list has no purpose. Removes the section, its refresh button, its state and its styles; discovery still feeds the Model field suggestions.
🤖 Generated with Claude Code