Repository navigation
fix: rank projects and models by the measure on show - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Bugfix
Overview
Switch to Est. cost, or flip Projects to Sessions, and both lists kept their token order with the new numbers on them. So the bars went up and down instead of getting shorter, and since Projects only shows the top 8, it was the top 8 by tokens - on my data, sorting by sessions left out two projects that should have been 4th and 5th. Both lists now sort by whatever they're showing.
Issue Number
n/a
Additional Info
Tools still keeps its fixed order, so it's sorted in the page rather than in the bar list. Model colours don't move when the order does. Checked in Chromium against a copy of my live database, no page errors.