[18.0][FIX] mis_builder: extend the MIS Builder menu in accounting to the Accounting Read Only group

[victoralmau]

Define the appropriate group in the menu

A user with the "Show Accounting Features - Read-only" group (account.group_account_readonly) should be able to view the menu

Please @pedrobaeza can you review it?

@Tecnativa TT63708

[OCA-git-bot]

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

[sbidoul]

We have an open issue to support that group: #619

But why changing it for the menu only when the child menu entries will not work?

[pedrobaeza]

@victoralmau please check that, and you should also check ir.model.access

[victoralmau]

But why changing it for the menu only when the child menu entries will not work?

The menu options do work because, at https://github.com/OCA/mis-builder/blob/18.0/mis_builder/security/ir.model.access.csv, base.group_user has read access.

[sbidoul]

Ah yes. So that's all we need to do to close #619 ?

[pedrobaeza]

@sbidoul indeed it's working:

and able to create MIS reports (and obviously read):

[pedrobaeza]

Ah yes. So that's all we need to do to close #619 ?

I would say yes according the testing I have just done.

[sbidoul]

Thanks!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[pedrobaeza]

@sbidoul should I trigger the merge command?

[sbidoul]

/ocabot merge minor

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-822-by-sbidoul-bump-minor, awaiting test results.

[sbidoul]

Thanks!

[OCA-git-bot]

Congratulations, your PR was merged at a87e304. Thanks a lot for contributing to OCA. ❤️