Skip to content

[17.0] [IMP] storage: Remove dependency on server_environment - #654

Open
yankinmax wants to merge 19 commits into
OCA:17.0from
camptocamp:17-storage-split
Open

[17.0] [IMP] storage: Remove dependency on server_environment#654
yankinmax wants to merge 19 commits into
OCA:17.0from
camptocamp:17-storage-split

Conversation

@yankinmax

@yankinmax yankinmax commented Aug 19, 2026

Copy link
Copy Markdown

@OCA-git-bot OCA-git-bot added mod:fs_storage Module fs_storage series:17.0 mod:fs_storage_environment Module fs_storage_environment labels Aug 19, 2026
@yankinmax
yankinmax marked this pull request as draft August 19, 2026 15:33
@OCA-git-bot OCA-git-bot added mod:fs_attachment Module fs_attachment mod:fs_attachment_s3 Module fs_attachment_s3 mod:fs_attachment_s3_environment Module fs_attachment_s3_environment mod:fs_attachment_environment Module fs_attachment_environment mod:storage_backend Module storage_backend mod:storage_backend_sftp Module storage_backend_sftp mod:storage_backend_environment Module storage_backend_environment mod:storage_backend_sftp_environment Module storage_backend_sftp_environment labels Aug 20, 2026
@yankinmax
yankinmax marked this pull request as ready for review August 20, 2026 08:31
@yankinmax

Copy link
Copy Markdown
Author

Hello @etobella @lmignon @ivantodorovich
In this PR I've cherry-picked the commits from merged 16.0 PR.
I squashed the commits that are related to one module split.
I've added new commits for storage_backend* modules.
The upgrade scripts and uninstall hooks are added for each module.
image_tag split is handled separately, because it doesn't introduce any server_env_fields override, so only need the upgrade script:

@yankinmax yankinmax changed the title [17.0] [IMP] fs_storage: Remove dependency on server_environment [17.0] [IMP] storage: Remove dependency on server_environment Aug 20, 2026

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the FWP

@ivantodorovich ivantodorovich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

"depends": ["fs_storage", "server_environment"],
"post_init_hook": "post_init_hook",
"uninstall_hook": "uninstall_hook",
"auto_install": True,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm are we sure we want to make these modules auto-install?
That means that if I still have server env installed for a different app (eg: mail) this module will be installed as well w/o any reason.
Since the migration is taking care of installing the modules I would say this has to change.
Am I missing any particular reason to keep auto-install?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:fs_attachment_environment Module fs_attachment_environment mod:fs_attachment_s3_environment Module fs_attachment_s3_environment mod:fs_attachment_s3 Module fs_attachment_s3 mod:fs_attachment Module fs_attachment mod:fs_storage_environment Module fs_storage_environment mod:fs_storage Module fs_storage mod:storage_backend_environment Module storage_backend_environment mod:storage_backend_sftp_environment Module storage_backend_sftp_environment mod:storage_backend_sftp Module storage_backend_sftp mod:storage_backend Module storage_backend series:17.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants