Preserve fuel labels in GraphML exports - #246
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #200.
Fuel nodes deliberately have blank labels in the rendered energy-system diagram, but exporting those blanks to GraphML leaves editors such as yEd without a readable fuel name.
Populate missing fuel labels with the node identifier in a copy used for GraphML export. Keep custom labels, the original graph, and the graph passed to the diagram renderer unchanged.
The regression round-trips the actual GraphML file and checks labels and edges, plus unchanged diagram labels. Only the external Graphviz image-rendering call is mocked.
Validation on Python 3.13: the missing-label regression fails before the fix; the full test suite passes afterward (254 passed, 1 existing skip). Black passes. Flake8 passes with the repository's setup.cfg (
python -m flake8 --config setup.cfg src/otoole/visualise/res.py tests/test_visualise.py, exit 0).git diff --checkpasses.Prepared with Codex assistance.