Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a dictated
你好,ZIPis corrected to你好,VIP, vocabulary learning currently suggests,Z → ,V: the character diff drops the sharedIP, then the minimum-length heuristic pulls in the comma. Adding a sentence-ending period instead causes the correction to be rejected. Internal spelling insertions such ascodx → codexare also lost because their source diff is empty.Recover complete ASCII words and technical identifiers after separating bounded character edits.
你好,ZIP → 你好,VIP。now producesZIP → VIP; punctuation and short continued typing are filtered independently, and multiple corrections are published separately. Validate length and vocabulary boundaries after expansion, deduplicate overlapping word candidates, and check each recovered source word against the inserted text before queueing it. Use only local processing and retain the existing user-confirmation flow: accepting this suggestion savesVIPwithout creating a globalZIP → VIPreplacement rule.The alignment is capped at 64 changed characters per side. Internal identifier separators are preserved; typical URLs, paths, emails, numeric-only changes, unsupported accented-word fragments, pure formatting, whole-word deletions and newly appended words are skipped. CJK context expansion remains a conservative heuristic, now restricted to Han characters rather than arbitrary neighboring punctuation.
Validation:
cargo test --locked -p openless-corecargo clippy --locked -p openless-core --all-targets -- -D warningsgit diff --check.This change does not alter native focus acquisition, AX notification timing, or macOS insertion anchoring. The recovered-word containment check cannot prove the edit location when the same word appears elsewhere in a document. No live-editor UI test or application installation was performed.