fix: make cold Windows recording bounded - #133
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The exact-SHA Production qualification ran the built 1.3.0 wheel in a fresh Windows environment. Native hooks started, but the first pywinauto/comtypes UI Automation setup exceeded the shared five-second limit. The normal Windows test job had warmed those imports before it started the recorder, so it didn't expose the cold path.
The first successful recorder shutdown also spent about 55 seconds building Matplotlib's font cache. Performance plotting was enabled by default even though it is a diagnostic.
What changed
plot_performance=Truestill enables it.Verification
git diff --checkpassed.The exact-SHA hosted Windows qualification must pass from a fresh built-wheel environment before release.