This repository was archived by the owner on Sep 24, 2019. It is now read-only.
Issue3 rebase - #58
Merged
Merged
Conversation
Need to review the term_argument action with Tony.
Added incomplete instance variable to each rl.
- simplify - call out ID_CHARS and break up remaining machine definitions (IDENT) - relocate yield action to instantiation
Need to go back and prune the old rules out.
I mixed actions with definitions. Oops. Also @'d when I should have %'d, and that's always a problem. Don't do that.
Still have problems parsing unclosed lists.
This is currently problematic since there are yields inside definitions where there shouldn't be. This is causing list specs to succeed and set specs to fail.
added 22 commits
May 16, 2016 11:16
Some of the more complex machines are only tested superficially.
Member
|
Nice work! Extensive changes to support complete/incomplete AST results. Minor points:
These point shouldn't stop us from merging. I can follow up with some issues once I start to use them. Thanks! |
This was referenced May 16, 2016
Closed
abargnesi
pushed a commit
that referenced
this pull request
May 17, 2016
This moved at some point. All but one test passes. refs #58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to close #3 and #4. Will need to expand observed, simple, and nested statement incomplete specs further but I'm hoping we can merge this first considering the broad changes.
Will have to duplicate v1_syntax specs to v2_syntax_specs and make the appropriate modifications as well.