Repository navigation
Don't clear state on SAML responses or error pages - #137
Closed
jorissteyn wants to merge 1 commit into
Closed
jorissteyn wants to merge 1 commit into
jorissteyn wants to merge 1 commit into
Conversation
When Stepup renders a SAML response or error page, the state of the
request is never reset. If for whatever reason the request to the
consume-assertion request happens twice, both requests succeed. Also,
if the user refreshes the error page, the exact same error
occurs. This is intended behaviour and a good thing.
When Stepup acts as a proxy for GSSP, the behaviour is different. The
state is cleared after consume-assertion and when rendering an error
page. When the error page is refreshed by the user, different errors
are triggered because the request does not match the state. For
example, this error might be logged when refreshing an error page:
Invalid Argument, parameter "requestId" should be of type "string", "NULL" given
This commit changes the proxy controllers to never reset the state
when a request is handled. The behaviour in Stepup is now consistent.
pmeulen
reviewed
Mar 9, 2018
| ]); | ||
|
|
||
| // clear the state so we can call again :) | ||
| $stateHandler->clear(); |
Member
There was a problem hiding this comment.
Part of the state is the ID from the SAML AuthnRequest. This is used for replay protection. The ID from the AuthnRequest must match the InResponseTo in the Response. It is correct to invalidate the ID after receiving a SAML Response. So resending a SAML Response could result in a different error.
I agree that from a user and support perspective it is nice if reloading an error page does not change the error. But this behaviour can be achieved by other means (e.g. by redirecting to an error URL).
Contributor
Author
There was a problem hiding this comment.
Thanks, the proper solution is a bit more complicated. I'm closing (and not merging) this PR and created a pivotal issue for further discussion on how to handle this in the future: https://www.pivotaltracker.com/story/show/155850805
This was referenced Nov 30, 2024
kayjoosten
added a commit
that referenced
this pull request
Jul 30, 2026
…icate Per Johan's review comment: this sanitization logic (truncate to 40 chars + ellipsis, whitespace collapse, control-char strip) existed as three independently-drifting copies (Gateway, Stepup-gssp-bundle, Stepup-Webauthn), one of which truncated to 41 chars instead of 40. Moved the canonical implementation to Stepup-saml-bundle, which both Gateway and gssp-bundle already depend on. gssp-bundle's own copy is removed in a companion PR (OpenConext/Stepup-gssp-bundle#49) so its ServiceNameResolver delegates to the same class - WebAuthn/DemoGSSP/Tiqr need no changes, they already only call gssp-bundle's ServiceNameResolver, never the formatter directly. Temporarily pinned to Stepup-saml-bundle's feature/issue-48-mdui-chunk branch (OpenConext/Stepup-saml-bundle#137, still open) via a VCS repository entry, matching the same pattern already used in gssp-bundle#49. Needs swapping to a tagged release once #137 merges.
kayjoosten
added a commit
that referenced
this pull request
Aug 3, 2026
surfnet/stepup-saml-bundle 7.1.0-beta1 (PR #137's branch tip) is now tagged, so this no longer needs to float on a dev-branch requirement. Verified: composer test (287/287), phpstan, phpcs all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Stepup renders a SAML response or error page, the state of the
request is never reset. If for whatever reason the request to the
consume-assertion request happens twice, both requests succeed. Also,
if the user refreshes the error page, the exact same error
occurs. This is intended behaviour and a good thing.
When Stepup acts as a proxy for GSSP, the behaviour is different. The
state is cleared after consume-assertion and when rendering an error
page. When the error page is refreshed by the user, different errors
are triggered because the request does not match the state. For
example, this error might be logged when refreshing an error page:
This commit changes the proxy controllers to never reset the state
when a request is handled. The behaviour in Stepup is now consistent.