Driver refactoring - #17
Merged
Merged
Conversation
Member
Author
|
Summoning @bendyer. |
pavel-kirienko
added a commit
that referenced
this pull request
Jul 18, 2026
Review finding #17 (Low). libcanard destroys a slot-free session once last_admission_ts falls behind the 2 s transfer-ID timeout (canard_poll); the 30 s retention window applies only to the slots themselves (rx_session_cleanup). Python retained slot-free sessions for the full 30 s, so during a redundant-bus failover a transfer reusing the last-admitted transfer-ID+priority from a different interface could be dropped for up to ~28 s longer than in the reference. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CabiCDQ5DNBYq8WDKRzG4Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
driverhas been converted into package.