Skip to content

fix(r1)!: rename PF_ALERT and MAC_PF_ALERT bit 25 from OPNC to OPNCELL - #100

Open
amandeavor wants to merge 2 commits into
OpenDevicePartnership:mainfrom
amandeavor:fix/r1-opncell-bit-25
Open

fix(r1)!: rename PF_ALERT and MAC_PF_ALERT bit 25 from OPNC to OPNCELL#100
amandeavor wants to merge 2 commits into
OpenDevicePartnership:mainfrom
amandeavor:fix/r1-opncell-bit-25

Conversation

@amandeavor

@amandeavor amandeavor commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Closes #99

Renames PF_ALERT and MAC_PF_ALERT bit 25 from OPNC to OPNCELL in device_r1.ddsl and regenerates src/versions/gen_r1.rs so pf_alert().opncell() and mac_pf_alert().opncell() match PF_STATUS and MAC_PF_STATUS.

BREAKING CHANGE: renames the public accessor opnc() / set_opnc() to opncell() / set_opncell() on r1 PfAlert and MacPfAlert.

@amandeavor
fix(r1)!: rename PF_ALERT and MAC_PF_ALERT bit 25 from OPNC to OPNCELL
04ddfa6 
Signed-off-by: Aman Awasthi <amandeavor@gmail.com>
Copilot AI balanced review requested due to automatic review settings October 23, 2026 16:52
@amandeavor
amandeavor requested a review from a team as a code owner October 23, 2026 16:52
Copilot AI reviewed Oct 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@amandeavor amandeavor changed the title fix(r1): correct SafetyStatusA opncell bit offset to 25 fix(r1): correct SafetyStatusA opncell bit offset to 25 Oct 23, 2026
@amandeavor amandeavor mentioned this pull request Oct 23, 2026
Open
@amandeavor amandeavor changed the title fix(r1): correct SafetyStatusA opncell bit offset to 25 fix(r1)!: rename PF_ALERT and MAC_PF_ALERT bit 25 from OPNC to OPNCELL Oct 23, 2026
@amandeavor

amandeavor commented Nov 9, 2026

Copy link
Copy Markdown
Author

cargo-deny currently fails on the merge ref with RUSTSEC-2026-0386 (tokio 1.52.3, unsound AsyncFd constructors), which is what failed attempt #2 in the earlier run. Pushed c7f695e bumping tokio from 1.52.3 to 1.54.1 per the advisory's fix range (cargo update -p tokio, no other change). The re-pushed workflows go back to action_required, so they need your approval to run again — after that, deny should be the only remaining red.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@colindonahue colindonahue Awaiting requested review from colindonahue colindonahue is a code owner automatically assigned from OpenDevicePartnership/ec-battery-team
@seanbrns seanbrns Awaiting requested review from seanbrns seanbrns is a code owner automatically assigned from OpenDevicePartnership/ec-battery-team
@chchongmsft chchongmsft Awaiting requested review from chchongmsft chchongmsft is a code owner automatically assigned from OpenDevicePartnership/ec-battery-team
@thdesil thdesil Awaiting requested review from thdesil thdesil is a code owner automatically assigned from OpenDevicePartnership/ec-battery-team

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

r1 names PF_ALERT bit 25 OPNC and PF_STATUS bit 25 OPNCELL (residual of #86)

2 participants

@amandeavor