fix: raise openjd-model floor to >= 0.11.4 - #354
Merged
leongdl merged 1 commit intoAug 19, 2026
Merged
Conversation
Signed-off-by: David Leong <leongdl@amazon.com>
crowecawcaw
approved these changes
Aug 19, 2026
godobyte
approved these changes
Aug 19, 2026
leongdl
enabled auto-merge (rebase)
August 19, 2026 16:32
jericht
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise the
openjd-modelfloor from>= 0.11.2to>= 0.11.4.openjd-model0.11.4 givesopenjd.expr.SerializedSymbolTablea JSON transport form (to_json_str/from_json_str). That transport is how a caller gets a resolved table across a process boundary and into the v1Session'sresolved_symtab— a scheduler resolves withcreate_job_with_symbol_tables, persists the JSON, and a worker reconstructs it. Before 0.11.4 the only constructor isfrom_symtab, so that path is not expressible andresolved_symtabis only usable in-process.Nothing in this package's own source calls the new accessors, so this is a floor raise for the caller contract, not an import requirement — sessions still imports fine against 0.11.2. The floor comment now also records the 0.11.2 hard lower bound (the EXPR/WRAP_ACTIONS model surface this package does import) so it does not get lowered past the point where imports break.
What was the problem/requirement? (What/Why)
openjd-model0.11.4 is released and on PyPI. The floor here still pointed at 0.11.2, so consumers resolvingopenjd-sessionscould land on a model version whoseSerializedSymbolTablecannot round-trip through JSON, leaving theresolved_symtabparameter half-usable.What was the solution? (How)
One-line floor bump in
pyproject.toml, plus a rewrite of the adjacent comment. The old comment said "0.11.1 is the floor" while the pin read 0.11.2; the replacement states the 0.11.4 rationale and keeps the 0.11.2 hard bound as a separate "do not drop below" note.What is the impact of this change?
Consumers of
openjd-sessionsmust resolveopenjd-model >= 0.11.4. No runtime behavior change in this package.How was this change tested?
pip install -e .resolvedopenjd-model 0.11.4, confirmedSerializedSymbolTable.to_json_str/.from_json_strare present, and rantest/openjd/sessions_v1,test_runner_base.py,test_runner_step_script.py: 183 passed, 11 skipped, 3 xfailed.Was this change documented?
The dependency comment in
pyproject.tomlis updated. No docstrings affected.Is this a breaking change?
No. It narrows a dependency range; the public interface is unchanged.
Does this change impact security?
No.
Cross-port to openjd-rs
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.