fix!: updates to path mapping - #5
Merged
Merged
Conversation
ddneilson
force-pushed
the
ddneilson/update_path_mapping
branch
from
September 13, 2023 16:45
97d06c9 to
3856d4c
Compare
AWS-Samuel
approved these changes
Sep 14, 2023
Two changes related to updates in the spec: 1. The field name `source_os` in a path mapping rule's definition was determined to be somewhat ambiguous in its meaning. So, it is being changed to `source_path_format`. 2. We passed path mapping rules in an environment variable before the introduction of the Session.PathMappingRulesFile value. With the creation of that value for format strings, we deprecated the PATH_MAPPING_RULES environment variable. It is time to delete it. **BREAKING CHANGE** 1. The format of the path mapping rules JSON is changed such that the 'source_os' key is now called 'source_path_format' 2. The PATH_MAPPING_RULES environment variable is no longer injected in to a running Session's environment. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
ddneilson
force-pushed
the
ddneilson/update_path_mapping
branch
from
September 14, 2023 18:17
3856d4c to
61777a1
Compare
jusiskin
approved these changes
Sep 14, 2023
mwiebe
approved these changes
Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Two changes related to updates in the spec:
source_osin a path mapping rule's definition was determined to be somewhat ambiguous in its meaning. So, it is being changed tosource_path_format.What was the solution? (How)
Apply the changes as described.
What is the impact of this change?
Compatibility with the spec that we are releasing.
How was this change tested?
This code is heavily unit/integration tested. Tests were updated and are passing.
Was this change documented?
Yes, in the specification documentation.
Is this a breaking change?
Yes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.