Skip to content

feat(onedrive_sharelink): support direct download redirects - #2591

Merged
xrgzs merged 1 commit into
OpenListTeam:mainfrom
syscc:fix/onedrive-sharelink-302
Jun 8, 2026
Merged

xrgzs merged 1 commit into
OpenListTeam:mainfrom
syscc:fix/onedrive-sharelink-302

Conversation

@syscc

@syscc syscc commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary / 摘要

  • Enable the Onedrive Sharelink driver to return redirect download links by resolving SharePoint item metadata and using @content.downloadUrl.

  • Preserve proxy/range-reader behavior for non-redirect link requests.

  • Remove OnlyProxy from the driver config so direct redirect downloads can be used.

  • Set a short local link cache TTL for temporary SharePoint tempauth URLs.

  • This PR has breaking changes.
    / 此 PR 包含破坏性变更。

  • This PR changes public API, config, storage format, or migration behavior.
    / 此 PR 修改了公开 API、配置、存储格式或迁移行为。

  • This PR requires corresponding changes in related repositories.
    / 此 PR 需要关联仓库同步修改。

Related repository PRs / 关联仓库 PR:

  • OpenList-Frontend: N/A
  • OpenList-Docs: N/A

Testing / 测试

  • go test ./...
  • go test ./drivers/onedrive_sharelink ./server/handles
  • Manual test / 手动测试:
    • Mounted a OneDrive ShareLink storage at /1.
    • Verified /d/1/01.mp4 returns 302 Found with a SharePoint download.aspx?...tempauth=... location instead of falling back to OpenList proxy.
    • Verified following the redirect with a range request returns 206 Partial Content directly from SharePoint.

Checklist / 检查清单

  • I have read CONTRIBUTING.
    / 我已阅读 CONTRIBUTING。
  • I confirm this contribution follows the repository license, contribution policy, and code of conduct.
    / 我确认此贡献符合仓库许可证、贡献规范和行为准则。
  • I have formatted the changed code with gofmt, go fmt, or prettier where applicable.
    / 我已按适用情况使用 gofmt、go fmt 或 prettier 格式化变更代码。
  • I have requested review from relevant maintainers or code owners where applicable.
    / 我已在适用情况下请求相关维护者或代码所有者审查。

AI Disclosure / AI 使用声明

  • This PR includes AI-assisted content.
    / 此 PR 包含 AI 辅助内容。

Tools used / 使用工具:

  • ChatGPT
  • Codex
  • GitHub Copilot
  • Claude
  • Gemini
  • Other (please specify) / 其他(请注明):

Usage scope / 使用范围:

  • Code generation / 代码生成

  • Refactoring / 重构

  • Documentation / 文档

  • Tests / 测试

  • Translation / 翻译

  • Review assistance / 审查辅助

  • I have reviewed and validated all AI-assisted content included in this PR.
    / 我已审核并验证此 PR 中的所有 AI 辅助内容。

  • I have ensured that all AI-assisted commits include Co-Authored-By attribution.
    / 我已确保所有 AI 辅助提交都包含 Co-Authored-By 归属信息。

  • I can reproduce all AI-assisted content included in this PR without any AI tools.
    / 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的 AI 辅助内容。

Resolve SharePoint item metadata to obtain @content.downloadUrl for redirect downloads.

Co-Authored-By: Codex <codex@openai.com>
@xrgzs xrgzs added enhancement Module: Driver Driver-Related Issue/PR labels Jun 8, 2026
@xrgzs xrgzs changed the title fix(onedrive_sharelink): support direct download redirects feat(onedrive_sharelink): support direct download redirects Jun 8, 2026
@syscc
syscc requested a review from jyxjjj June 8, 2026 03:32
@xrgzs
xrgzs removed the request for review from jyxjjj June 8, 2026 03:37
@xrgzs
xrgzs merged commit 9737006 into OpenListTeam:main Jun 8, 2026
14 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jul 1, 2026
1 task done
EnterTang pushed a commit to EnterTang/OpenList that referenced this pull request Jul 12, 2026
…Team#2591)

fix(onedrive_sharelink): support direct download redirects

Resolve SharePoint item metadata to obtain @content.downloadUrl for redirect downloads.

Co-authored-by: syscc <syscc@users.noreply.github.com>
Co-authored-by: Codex <codex@openai.com>
lyy2005a2 pushed a commit to lyy2005a2/OpenList that referenced this pull request Aug 7, 2026
…Team#2591)

fix(onedrive_sharelink): support direct download redirects

Resolve SharePoint item metadata to obtain @content.downloadUrl for redirect downloads.

Co-authored-by: syscc <syscc@users.noreply.github.com>
Co-authored-by: Codex <codex@openai.com>
cjd6568358 pushed a commit to cjd6568358/OpenList-zig that referenced this pull request Oct 18, 2026
…Team#2591)

fix(onedrive_sharelink): support direct download redirects

Resolve SharePoint item metadata to obtain @content.downloadUrl for redirect downloads.

Co-authored-by: syscc <syscc@users.noreply.github.com>
Co-authored-by: Codex <codex@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Module: Driver Driver-Related Issue/PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants